From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Mon, 21 Jan 2008 16:25:34 -0600 Subject: [Cluster-devel] [PATCH] dlm: clear ast_type when removing from astqueue Message-ID: <1200954344-17298-10-git-send-email-teigland@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit The lkb_ast_type field indicates whether the lkb is on the astqueue list. When clearing locks for a process, lkb's were being removed from the astqueue list without clearing the field. If release_lockspace then happened immediately afterward, it could try to remove the lkb from the list a second time. Appears when process calls libdlm dlm_release_lockspace() which first closes the ls dev triggering clear_proc_locks, and then removes the ls (a write to control dev) causing release_lockspace(). Signed-off-by: David Teigland --- fs/dlm/lock.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index ddb4628..43ca2a3 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -4678,6 +4678,7 @@ void dlm_clear_proc_locks(struct dlm_ls *ls, struct dlm_user_proc *proc) } list_for_each_entry_safe(lkb, safe, &proc->asts, lkb_astqueue) { + lkb->lkb_ast_type = 0; list_del(&lkb->lkb_astqueue); dlm_put_lkb(lkb); } -- 1.5.3.3