[Cluster-devel] [PATCH] dlm close othercons

[Cluster-devel] [PATCH] dlm close othercons

[Patrick Caulfeld]

This patch addresses a problem introduced with the last round of
lowcomms patches where the 'othercon' connections do not get freed when
the DLM shuts down.

This results in the error message
"slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all
objects"

and the DLM cannot be restarted without a system reboot.

See bz#428119

Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: con-free.patch
Type: text/x-patch
Size: 352 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20080109/2e37afa7/attachment.bin>

[Cluster-devel] [PATCH] dlm close othercons

[Steven Whitehouse]

Hi,

Now in the -nmw git tree. Thanks,

Steve.

On Wed, 2008-01-09 at 15:06 +0000, Patrick Caulfeld wrote:
> This patch addresses a problem introduced with the last round of
> lowcomms patches where the 'othercon' connections do not get freed when
> the DLM shuts down.
> 
> This results in the error message
> "slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all
> objects"
> 
> and the DLM cannot be restarted without a system reboot.
> 
> See bz#428119
> 
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>

[Cluster-devel] [PATCH] dlm close othercons

[Fabio M. Di Nitto]

On Wed, 9 Jan 2008, Patrick Caulfeld wrote:

> This patch addresses a problem introduced with the last round of
> lowcomms patches where the 'othercon' connections do not get freed when
> the DLM shuts down.
>
> This results in the error message
> "slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all
> objects"
>
> and the DLM cannot be restarted without a system reboot.
>
> See bz#428119
>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>

http://git.kernel.org/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=89f0bb2873fcaa8e57831dd3f0c013cabbd99012

this doesn't look right...

shouldn't we free the con->other _before_ we free con?

That's what we were doing before applying all that patch set that removed 
the original kmem_cache_free...

Fabio

--
I'm going to make him an offer he can't refuse.

[Cluster-devel] [PATCH] dlm close othercons

[Patrick Caulfeld]

Fabio M. Di Nitto wrote:
> On Wed, 9 Jan 2008, Patrick Caulfeld wrote:
> 
>> This patch addresses a problem introduced with the last round of
>> lowcomms patches where the 'othercon' connections do not get freed when
>> the DLM shuts down.
>>
>> This results in the error message
>> "slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all
>> objects"
>>
>> and the DLM cannot be restarted without a system reboot.
>>
>> See bz#428119
>>
>> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>>
> 
> http://git.kernel.org/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=89f0bb2873fcaa8e57831dd3f0c013cabbd99012
> 
> 
> this doesn't look right...
> 
> shouldn't we free the con->other _before_ we free con?
> 
> That's what we were doing before applying all that patch set that
> removed the original kmem_cache_free...
> 


ARGH! you're right, of course. Patch to fix is attached.

Thanks Fabio, I'm glad that someone reads my patches ... I just wish it
had been me ;-)

Patrick

Signed-off-by: Patrick Caulfield <pcaulfie@redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: free2.patch
Type: text/x-patch
Size: 428 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20080118/8a5c7c46/attachment.bin>

[Cluster-devel] [PATCH] dlm close othercons

[Fabio M. Di Nitto]

On Fri, 18 Jan 2008, Patrick Caulfeld wrote:

> Fabio M. Di Nitto wrote:
>> On Wed, 9 Jan 2008, Patrick Caulfeld wrote:
>>
>>> This patch addresses a problem introduced with the last round of
>>> lowcomms patches where the 'othercon' connections do not get freed when
>>> the DLM shuts down.
>>>
>>> This results in the error message
>>> "slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all
>>> objects"
>>>
>>> and the DLM cannot be restarted without a system reboot.
>>>
>>> See bz#428119
>>>
>>> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>>>
>>
>> http://git.kernel.org/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=89f0bb2873fcaa8e57831dd3f0c013cabbd99012
>>
>>
>> this doesn't look right...
>>
>> shouldn't we free the con->other _before_ we free con?
>>
>> That's what we were doing before applying all that patch set that
>> removed the original kmem_cache_free...
>>
>
>
> ARGH! you're right, of course. Patch to fix is attached.
>
> Thanks Fabio, I'm glad that someone reads my patches ... I just wish it
> had been me ;-)
>
> Patrick
>
> Signed-off-by: Patrick Caulfield <pcaulfie@redhat.com>
>

Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>

Fabio

--
I'm going to make him an offer he can't refuse.

[Cluster-devel] [PATCH] dlm: close othercons

[David Teigland]

From: Patrick Caulfeld <pcaulfie@redhat.com>

This patch addresses a problem introduced with the last round of
lowcomms patches where the 'othercon' connections do not get freed when
the DLM shuts down.

This results in the error message
"slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all
objects"

and the DLM cannot be restarted without a system reboot.

See bz#428119

Signed-off-by: Patrick Caulfield <pcaulfie@redhat.com>
Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>
Signed-off-by: David Teigland <teigland@redhat.com>
---
 fs/dlm/lowcomms.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 0bea802..b1cb855 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1437,6 +1437,8 @@ void dlm_lowcomms_stop(void)
 		con = __nodeid2con(i, 0);
 		if (con) {
 			close_connection(con, true);
+			if (con->othercon)
+				kmem_cache_free(con_cache, con->othercon);
 			kmem_cache_free(con_cache, con);
 		}
 	}
-- 
1.5.3.3