From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH RHEL6 1/2] tunegfs2: Ensure we don't try to open a null device
Date: Mon, 25 Jul 2011 13:18:47 -0400 (EDT) [thread overview]
Message-ID: <1201055384.254059.1311614327387.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1311613384-24929-1-git-send-email-anprice@redhat.com>
----- Original Message -----
| This is based on upstream commit
| a830c8747cf7dcc899dc92ad13c3a3b1a3738092
|
| Return codes are now taken from sysexits.h rather than trying to pass
| negative
| errno values as per kernel code. There is not an exact error code for
| all
| potential events, but they are close enough I think.
|
| The code also checks that there is exactly one non-option argument
| (i.e. the
| device) given before attempting to open it.
|
| rhbz#719124
|
| Signed-off-by: Andrew Price <anprice@redhat.com>
| Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
| Reported-by: Nathan Straz <nstraz@redhat.com>
Hi,
Looks good. ACK.
Bob Peterson
Red Hat File Systems
prev parent reply other threads:[~2011-07-25 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 17:03 [Cluster-devel] [PATCH RHEL6 1/2] tunegfs2: Ensure we don't try to open a null device Andrew Price
2011-07-25 17:03 ` [Cluster-devel] [PATCH RHEL6 2/2] tunegfs2: Fix usage message Andrew Price
2011-07-25 17:19 ` Bob Peterson
2011-07-25 17:40 ` Steven Whitehouse
2011-07-25 17:18 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201055384.254059.1311614327387.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).