* [Cluster-devel] [GFS2 PATCH] Plug an unlikely leak
@ 2008-01-28 22:35 Bob Peterson
2008-01-29 8:41 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2008-01-28 22:35 UTC (permalink / raw)
To: cluster-devel.redhat.com
--
fs/gfs2/lops.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index 7138737..4390f6f 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,
blkno = be64_to_cpu(*(__be64 *)(bh->b_data + offset));
error = gfs2_revoke_add(sdp, blkno, start);
- if (error < 0)
+ if (error < 0) {
+ brelse(bh);
return error;
+ }
else if (error)
sdp->sd_found_revokes++;
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [GFS2 PATCH] Plug an unlikely leak
2008-01-28 22:35 [Cluster-devel] [GFS2 PATCH] Plug an unlikely leak Bob Peterson
@ 2008-01-29 8:41 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2008-01-29 8:41 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nme git tree. Thanks,
Steve.
On Mon, 2008-01-28 at 16:35 -0600, Bob Peterson wrote:
> --
> fs/gfs2/lops.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index 7138737..4390f6f 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,
> blkno = be64_to_cpu(*(__be64 *)(bh->b_data + offset));
>
> error = gfs2_revoke_add(sdp, blkno, start);
> - if (error < 0)
> + if (error < 0) {
> + brelse(bh);
> return error;
> + }
> else if (error)
> sdp->sd_found_revokes++;
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-29 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-28 22:35 [Cluster-devel] [GFS2 PATCH] Plug an unlikely leak Bob Peterson
2008-01-29 8:41 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).