From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] Plug an unlikely leak
Date: Tue, 29 Jan 2008 08:41:25 +0000 [thread overview]
Message-ID: <1201596085.22038.326.camel@quoit> (raw)
In-Reply-To: <1201559713.18461.99.camel@technetium.msp.redhat.com>
Hi,
Now in the -nme git tree. Thanks,
Steve.
On Mon, 2008-01-28 at 16:35 -0600, Bob Peterson wrote:
> --
> fs/gfs2/lops.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index 7138737..4390f6f 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,
> blkno = be64_to_cpu(*(__be64 *)(bh->b_data + offset));
>
> error = gfs2_revoke_add(sdp, blkno, start);
> - if (error < 0)
> + if (error < 0) {
> + brelse(bh);
> return error;
> + }
> else if (error)
> sdp->sd_found_revokes++;
>
>
>
prev parent reply other threads:[~2008-01-29 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 22:35 [Cluster-devel] [GFS2 PATCH] Plug an unlikely leak Bob Peterson
2008-01-29 8:41 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201596085.22038.326.camel@quoit \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).