From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Tue, 29 Jan 2008 08:41:25 +0000
Subject: [Cluster-devel] [GFS2 PATCH] Plug an unlikely leak
In-Reply-To: <1201559713.18461.99.camel@technetium.msp.redhat.com>
References: <1201559713.18461.99.camel@technetium.msp.redhat.com>
Message-ID: <1201596085.22038.326.camel@quoit>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

Now in the -nme git tree. Thanks,

Steve.

On Mon, 2008-01-28 at 16:35 -0600, Bob Peterson wrote:
> --
>  fs/gfs2/lops.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index 7138737..4390f6f 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,
>  			blkno = be64_to_cpu(*(__be64 *)(bh->b_data + offset));
>  
>  			error = gfs2_revoke_add(sdp, blkno, start);
> -			if (error < 0)
> +			if (error < 0) {
> +				brelse(bh);
>  				return error;
> +			}
>  			else if (error)
>  				sdp->sd_found_revokes++;
>  
> 
>