cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2][PATCH] Remove unused counters
Date: Wed, 06 Feb 2008 11:04:30 +0000	[thread overview]
Message-ID: <1202295870.3748.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1202253101.7223.9.camel@technetium.msp.redhat.com>

Hi,

Now in the -nmw git tree. Thanks,

Steve.


On Tue, 2008-02-05 at 17:11 -0600, Bob Peterson wrote:
> Hi,
> 
> This is kind of trivial in the greater scheme of things, but
> this removes three counters that AFAICT are never used.
> 
> Regards,
> 
> Bob Peterson
> Red Hat GFS
> 
> Signed-off-by: Bob Peterson <rpeterso@redhat.com> 
> --
>  fs/gfs2/incore.h |    3 ---
>  fs/gfs2/sys.c    |    6 ------
>  2 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
> index 4c921ec..891b730 100644
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -636,9 +636,6 @@ struct gfs2_sbd {
>  
>  	/* Counters */
>  
> -	atomic_t sd_glock_count;
> -	atomic_t sd_glock_held_count;
> -	atomic_t sd_inode_count;
>  	atomic_t sd_reclaimed;
>  
>  	char sd_fsname[GFS2_FSNAME_LEN];
> diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
> index cc35ec8..9ab9fc8 100644
> --- a/fs/gfs2/sys.c
> +++ b/fs/gfs2/sys.c
> @@ -327,15 +327,9 @@ static ssize_t name##_show(struct gfs2_sbd *sdp, char *buf)                 \
>  }                                                                           \
>  static struct counters_attr counters_attr_##name = __ATTR_RO(name)
>  
> -COUNTERS_ATTR(glock_count,      "%u\n");
> -COUNTERS_ATTR(glock_held_count, "%u\n");
> -COUNTERS_ATTR(inode_count,      "%u\n");
>  COUNTERS_ATTR(reclaimed,        "%u\n");
>  
>  static struct attribute *counters_attrs[] = {
> -	&counters_attr_glock_count.attr,
> -	&counters_attr_glock_held_count.attr,
> -	&counters_attr_inode_count.attr,
>  	&counters_attr_reclaimed.attr,
>  	NULL,
>  };
> 
> 



      reply	other threads:[~2008-02-06 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 23:11 [Cluster-devel] [GFS2][PATCH] Remove unused counters Bob Peterson
2008-02-06 11:04 ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202295870.3748.0.camel@localhost.localdomain \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).