[Cluster-devel] [GFS2][PATCH] Remove unused counters

[Cluster-devel] [GFS2][PATCH] Remove unused counters

[Bob Peterson]

Hi,

This is kind of trivial in the greater scheme of things, but
this removes three counters that AFAICT are never used.

Regards,

Bob Peterson
Red Hat GFS

Signed-off-by: Bob Peterson <rpeterso@redhat.com> 
--
 fs/gfs2/incore.h |    3 ---
 fs/gfs2/sys.c    |    6 ------
 2 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 4c921ec..891b730 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -636,9 +636,6 @@ struct gfs2_sbd {
 
 	/* Counters */
 
-	atomic_t sd_glock_count;
-	atomic_t sd_glock_held_count;
-	atomic_t sd_inode_count;
 	atomic_t sd_reclaimed;
 
 	char sd_fsname[GFS2_FSNAME_LEN];
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index cc35ec8..9ab9fc8 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -327,15 +327,9 @@ static ssize_t name##_show(struct gfs2_sbd *sdp, char *buf)                 \
 }                                                                           \
 static struct counters_attr counters_attr_##name = __ATTR_RO(name)
 
-COUNTERS_ATTR(glock_count,      "%u\n");
-COUNTERS_ATTR(glock_held_count, "%u\n");
-COUNTERS_ATTR(inode_count,      "%u\n");
 COUNTERS_ATTR(reclaimed,        "%u\n");
 
 static struct attribute *counters_attrs[] = {
-	&counters_attr_glock_count.attr,
-	&counters_attr_glock_held_count.attr,
-	&counters_attr_inode_count.attr,
 	&counters_attr_reclaimed.attr,
 	NULL,
 };

[Cluster-devel] [GFS2][PATCH] Remove unused counters

[Steven Whitehouse]

Hi,

Now in the -nmw git tree. Thanks,

Steve.


On Tue, 2008-02-05 at 17:11 -0600, Bob Peterson wrote:
> Hi,
> 
> This is kind of trivial in the greater scheme of things, but
> this removes three counters that AFAICT are never used.
> 
> Regards,
> 
> Bob Peterson
> Red Hat GFS
> 
> Signed-off-by: Bob Peterson <rpeterso@redhat.com> 
> --
>  fs/gfs2/incore.h |    3 ---
>  fs/gfs2/sys.c    |    6 ------
>  2 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
> index 4c921ec..891b730 100644
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -636,9 +636,6 @@ struct gfs2_sbd {
>  
>  	/* Counters */
>  
> -	atomic_t sd_glock_count;
> -	atomic_t sd_glock_held_count;
> -	atomic_t sd_inode_count;
>  	atomic_t sd_reclaimed;
>  
>  	char sd_fsname[GFS2_FSNAME_LEN];
> diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
> index cc35ec8..9ab9fc8 100644
> --- a/fs/gfs2/sys.c
> +++ b/fs/gfs2/sys.c
> @@ -327,15 +327,9 @@ static ssize_t name##_show(struct gfs2_sbd *sdp, char *buf)                 \
>  }                                                                           \
>  static struct counters_attr counters_attr_##name = __ATTR_RO(name)
>  
> -COUNTERS_ATTR(glock_count,      "%u\n");
> -COUNTERS_ATTR(glock_held_count, "%u\n");
> -COUNTERS_ATTR(inode_count,      "%u\n");
>  COUNTERS_ATTR(reclaimed,        "%u\n");
>  
>  static struct attribute *counters_attrs[] = {
> -	&counters_attr_glock_count.attr,
> -	&counters_attr_glock_held_count.attr,
> -	&counters_attr_inode_count.attr,
>  	&counters_attr_reclaimed.attr,
>  	NULL,
>  };
> 
>