From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Thu, 14 Feb 2008 10:44:34 +0000 Subject: [Cluster-devel] Re: gfs2_fh_to_parent() array overflow In-Reply-To: <20080213213112.GU3383@cs181133002.pp.htv.fi> References: <20071024162626.GJ30533@stusta.de> <20071027210039.GA2688@lst.de> <1193649081.1068.462.camel@quoit> <20080213213112.GU3383@cs181133002.pp.htv.fi> Message-ID: <1202985874.22038.455.camel@quoit> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote: > On Mon, Oct 29, 2007 at 09:11:21AM +0000, Steven Whitehouse wrote: > > Hi, > > > > On Sat, 2007-10-27 at 23:00 +0200, Christoph Hellwig wrote: > > > On Wed, Oct 24, 2007 at 06:26:26PM +0200, Adrian Bunk wrote: > > > > The Coverity checker spotted the following array overflow caused by > > > > commit 34c0d154243dd913c5690ae6ceb9557017429b9c: > > > > > > The line is a left-over from times when gfs stored the mode of the > > > inode in the file handle. It can simply be deleted. Steve, do you > > > want a patch for that or could you commit that one-liner directly? > > > > > > > I'm just back from holiday this morning and this is looking a bit more > > complicated than that... give me a day or two and I'll try and come up > > with a solution, > > This issue is still present in 2.6.25-rc1. > Yes, it seems to have slipped off my list somehow... I've opened a bz (#432775 at bugzilla.redhat.com) to ensure that it doesn't get missed again, Steve.