From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/3] gfs2: Don't depend on mp_aheight in clone_metapath
Date: Mon, 30 Jul 2018 16:06:01 -0400 (EDT) [thread overview]
Message-ID: <1203799916.55813140.1532981161695.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180730123353.15815-1-agruenba@redhat.com>
----- Original Message -----
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
> fs/gfs2/bmap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
> index 03128ed1f34e..a564cf0b7221 100644
> --- a/fs/gfs2/bmap.c
> +++ b/fs/gfs2/bmap.c
> @@ -294,8 +294,11 @@ static void clone_metapath(struct metapath *clone,
> struct metapath *mp)
> unsigned int hgt;
>
> *clone = *mp;
> - for (hgt = 0; hgt < mp->mp_aheight; hgt++)
> + for (hgt = 0; hgt < GFS2_MAX_META_HEIGHT; hgt++) {
> + if (mp->mp_bh[hgt] == NULL)
> + break;
> get_bh(clone->mp_bh[hgt]);
> + }
> }
>
> static void gfs2_metapath_ra(struct gfs2_glock *gl, __be64 *start, __be64
> *end)
> --
> 2.17.1
>
>
Hi,
Reviewed-by: Bob Peterson <rpeterso@redhat.com>
Bob Peterson
prev parent reply other threads:[~2018-07-30 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 12:33 [Cluster-devel] [PATCH 1/3] gfs2: Don't depend on mp_aheight in clone_metapath Andreas Gruenbacher
2018-07-30 12:33 ` [Cluster-devel] [PATCH 2/3] gfs2: Split gfs2_indirect_init Andreas Gruenbacher
2018-07-30 20:06 ` Bob Peterson
2018-07-30 12:33 ` [Cluster-devel] [PATCH 3/3] gfs2: Don't create unnecessary indirect blocks Andreas Gruenbacher
2018-07-30 20:12 ` Bob Peterson
2018-07-30 14:29 ` [Cluster-devel] [PATCH 1/3] gfs2: Don't depend on mp_aheight in clone_metapath Andreas Gruenbacher
2018-07-30 20:06 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203799916.55813140.1532981161695.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).