cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Lon Hohberger <lhh@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Make fenced manual override work as fencing
Date: Wed, 27 Feb 2008 17:16:46 -0500	[thread overview]
Message-ID: <1204150606.13733.0.camel@ayanami.boston.devel.redhat.com> (raw)
In-Reply-To: <12041505444146-git-send-email-lhh@redhat.com>

On Wed, 2008-02-27 at 17:15 -0500, Lon Hohberger wrote:
> This patch corrects a bug in fenced which prevents manual
> override from being reported to CMAN

Er, whoops.  Here's the patch.

diff --git a/fence/fenced/agent.c b/fence/fenced/agent.c
index 65cb30c..0577e8f 100644
--- a/fence/fenced/agent.c
+++ b/fence/fenced/agent.c
@@ -279,7 +279,7 @@ static int use_device(int cd, char *victim, char
*method, int d,
 	return error;
 }
 
-static void update_cman(char *victim, char *method)
+void update_cman(char *victim, char *method)
 {
 	cman_handle_t ch;
 	struct cman_node node;
diff --git a/fence/fenced/fd.h b/fence/fenced/fd.h
index 988a412..0b78d19 100644
--- a/fence/fenced/fd.h
+++ b/fence/fenced/fd.h
@@ -192,5 +192,6 @@ int update_cluster_members(void);
 int is_member(char *name);
 int is_fenced(char *name);
 fd_node_t *get_new_node(fd_t *fd, int nodeid, char *in_name);
+void update_cman(char *victim, char *agent);
 
 #endif				/*  __FD_DOT_H__  */
diff --git a/fence/fenced/recover.c b/fence/fenced/recover.c
index 82a3c42..7f8aace 100644
--- a/fence/fenced/recover.c
+++ b/fence/fenced/recover.c
@@ -406,6 +406,7 @@ static void fence_victims(fd_t *fd, int start_type)
 			syslog(LOG_WARNING, "fence \"%s\" overridden by "
 			       "administrator intervention", node->name);
 
+			update_cman(node->name, "override");
 			list_del(&node->list);
 			free(node);
 		}




  reply	other threads:[~2008-02-27 22:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 22:15 [Cluster-devel] [PATCH] Make fenced manual override work as fencing Lon Hohberger
2008-02-27 22:16 ` Lon Hohberger [this message]
2008-02-29 19:24   ` Lon Hohberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204150606.13733.0.camel@ayanami.boston.devel.redhat.com \
    --to=lhh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).