From mboxrd@z Thu Jan  1 00:00:00 1970
From: swhiteho@redhat.com <swhiteho@redhat.com>
Date: Thu, 17 Apr 2008 09:38:45 +0100
Subject: [Cluster-devel] [PATCH 09/48] [GFS2] Plug an unlikely leak
In-Reply-To: <12084215851158-git-send-email-swhiteho@redhat.com>
References: 12084214272083-git-send-email-swhiteho@redhat.com
	<12084215642582-git-send-email-swhiteho@redhat.com>
	<1208421571478-git-send-email-swhiteho@redhat.com>
	<12084215742081-git-send-email-swhiteho@redhat.com>
	<12084215763647-git-send-email-swhiteho@redhat.com>
	<12084215781246-git-send-email-swhiteho@redhat.com>
	<12084215802470-git-send-email-swhiteho@redhat.com>
	<12084215833555-git-send-email-swhiteho@redhat.com>
	<12084215851158-git-send-email-swhiteho@redhat.com>
Message-ID: <120842158797-git-send-email-swhiteho@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

From: Bob Peterson <rpeterso@redhat.com>

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index 7138737..4390f6f 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,
 			blkno = be64_to_cpu(*(__be64 *)(bh->b_data + offset));
 
 			error = gfs2_revoke_add(sdp, blkno, start);
-			if (error < 0)
+			if (error < 0) {
+				brelse(bh);
 				return error;
+			}
 			else if (error)
 				sdp->sd_found_revokes++;
 
-- 
1.5.1.2