From mboxrd@z Thu Jan  1 00:00:00 1970
From: swhiteho@redhat.com <swhiteho@redhat.com>
Date: Thu, 17 Apr 2008 09:39:18 +0100
Subject: [Cluster-devel] [PATCH 42/48] [GFS2] Remove drop of module ref
	where not needed
In-Reply-To: <12084216533319-git-send-email-swhiteho@redhat.com>
References: 12084214272083-git-send-email-swhiteho@redhat.com
	<12084215642582-git-send-email-swhiteho@redhat.com>
	<1208421571478-git-send-email-swhiteho@redhat.com>
	<12084215742081-git-send-email-swhiteho@redhat.com>
	<12084215763647-git-send-email-swhiteho@redhat.com>
	<12084215781246-git-send-email-swhiteho@redhat.com>
	<12084215802470-git-send-email-swhiteho@redhat.com>
	<12084215833555-git-send-email-swhiteho@redhat.com>
	<12084215851158-git-send-email-swhiteho@redhat.com>
	<120842158797-git-send-email-swhiteho@redhat.com>
	<12084215891940-git-send-email-swhiteho@redhat.com>
	<12084215913125-git-send-email-swhiteho@redhat.com>
	<12084215931509-git-send-email-swhiteho@redhat.com>
	<12084215961690-git-send-email-swhiteho@redhat.com>
	<1208421597980-git-send-email-swhiteho@redhat.com>
	<12084216003676-git-send-email-swhiteho@redhat.com>
	<12084216023999-git-send-email-swhiteho@redhat.com>
	<12084216044123-git-send-email-swhiteho@redhat.com>
	<12084216061172-git-send-email-swhiteho@redhat.com>
	<12084216082638-git-send-email-swhiteho@redhat.com>
	<12084216101961-git-send-email-swhiteho@redhat.com>
	<12084216121811-git-send-email-swhiteho@redhat.com>
	<12084216153016-git-send-email-swhiteho@redhat.com>
	<1208421617421-git-send-email-swhiteho@redhat.com>
	<12084216182363-git-send-email-swhiteho@redhat.com>
	<12084216204027-git-send-email-swhiteho@redhat.com>
	<12084216222853-git-send-email-swhiteho@redhat.com>
	<12084216241802-git-send-email-swhiteho@redhat.com>
	<12084216262937-git-send-email-swhiteho@redhat.com>
	<12084216281152-git-send-email-swhiteho@redhat.com>
	<12084216301107-git-send-email-swhiteho@redhat.com>
	<12084216323165-git-send-email-swhiteho@redhat.com>
	<1208421634101-git-send-email-swhiteho@redhat.com>
	<12084216372363-git-send-email-swhiteho@redhat.com>
	<12084216391215-git-send-email-swhiteho@redhat.com>
	<12084216402644-git-send-email-swhiteho@redhat.com>
	<12084216431261-git-send-email-swhiteho@redhat.com>
	<1208421645785-git-send-email-swhiteho@redhat.com>
	<1208421647805-git-send-email-swhiteho@redhat.com>
	<12084216494161-git-send-email-swhiteho@redhat.com>
	<12084216511207-git-send-email-swhiteho@redhat.com>
	<12084216533319-git-send-email-swhiteho@redhat.com>
Message-ID: <12084216553542-git-send-email-swhiteho@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

From: Steven Whitehouse <swhiteho@redhat.com>

In an earlier patch "[GFS2] fix file_system_type leak on gfs2meta mount"
we removed the code to grab a ref to the module which was not needed
(since we know that the module cannot be unloaded at that time) so
this patch removes the code to drop that reference.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 63d5fd2..5b518f7 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -998,7 +998,6 @@ static int gfs2_get_sb_meta(struct file_system_type *fs_type, int flags,
 		error = PTR_ERR(new);
 		goto error;
 	}
-	module_put(fs_type->owner);
 	new->s_flags = flags;
 	strlcpy(new->s_id, sb->s_id, sizeof(new->s_id));
 	sb_set_blocksize(new, sb->s_blocksize);
-- 
1.5.1.2