cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 07/12] GFS2: Direct IO write at end of file error
Date: Fri, 26 Sep 2008 13:00:50 +0100	[thread overview]
Message-ID: <1222430455-4632-8-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1222430455-4632-7-git-send-email-swhiteho@redhat.com>

From: Bob Peterson <rpeterso@redhat.com>

This patch fixes a problem whereby a direct_io write doesn't fall
back to buffered write properly at end of file.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/ops_address.c b/fs/gfs2/ops_address.c
index e64a1b0..ae7126a 100644
--- a/fs/gfs2/ops_address.c
+++ b/fs/gfs2/ops_address.c
@@ -975,7 +975,7 @@ static int gfs2_ok_for_dio(struct gfs2_inode *ip, int rw, loff_t offset)
 	if (gfs2_is_stuffed(ip))
 		return 0;
 
-	if (offset > i_size_read(&ip->i_inode))
+	if (offset >= i_size_read(&ip->i_inode))
 		return 0;
 	return 1;
 }
-- 
1.5.5.1



  reply	other threads:[~2008-09-26 12:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26 12:00 [Cluster-devel] GFS2: Pre-pull patch posting Steven Whitehouse
2008-09-26 12:00 ` [Cluster-devel] [PATCH 01/12] GFS2: Fix debugfs glock file iterator Steven Whitehouse
2008-09-26 12:00   ` [Cluster-devel] [PATCH 02/12] GFS2: Fix metafs mounts Steven Whitehouse
2008-09-26 12:00     ` [Cluster-devel] [PATCH 03/12] GFS2: rm on multiple nodes causes panic Steven Whitehouse
2008-09-26 12:00       ` [Cluster-devel] [PATCH 04/12] GFS2: Fix & clean up GFS2 rename Steven Whitehouse
2008-09-26 12:00         ` [Cluster-devel] [PATCH 05/12] GFS2: Fix race relating to glock min-hold time Steven Whitehouse
2008-09-26 12:00           ` [Cluster-devel] [PATCH 06/12] GFS2: Use an IS_ERR test rather than a NULL test Steven Whitehouse
2008-09-26 12:00             ` Steven Whitehouse [this message]
2008-09-26 12:00               ` [Cluster-devel] [PATCH 08/12] GFS2: GFS2 will panic if you misspell any mount options Steven Whitehouse
2008-09-26 12:00                 ` [Cluster-devel] [PATCH 09/12] GFS2: The war on bloat Steven Whitehouse
2008-09-26 12:00                   ` [Cluster-devel] [PATCH 10/12] GFS2: high time to take some time over atime Steven Whitehouse
2008-09-26 12:00                     ` [Cluster-devel] [PATCH 11/12] GFS2: Add UUID to GFS2 sb Steven Whitehouse
2008-09-26 12:00                       ` [Cluster-devel] [PATCH 12/12] GFS2: Support for I/O barriers Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222430455-4632-8-git-send-email-swhiteho@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).