From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Wed, 15 Apr 2009 09:58:48 +0100 Subject: [Cluster-devel] Re: [PATCH 5/7] gfs2: Remove code handling bio_alloc failure with __GFP_WAIT In-Reply-To: <200904151036.35481.knikanth@suse.de> References: <200904151036.35481.knikanth@suse.de> Message-ID: <1239785928.3377.1.camel@localhost.localdomain> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Acked-by: Steven Whitehouse I could put this in my tree, but I think that Jens is going to push this one to Linus, so I'm holding off, Steve. On Wed, 2009-04-15 at 10:36 +0530, Nikanth Karthikesan wrote: > Remove code handling bio_alloc failure with __GFP_WAIT. > GFP_NOFS implies __GFP_WAIT. > > Signed-off-by: Nikanth Karthikesan > > --- > > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c > index 51883b3..650a730 100644 > --- a/fs/gfs2/ops_fstype.c > +++ b/fs/gfs2/ops_fstype.c > @@ -272,11 +272,6 @@ static int gfs2_read_super(struct gfs2_sbd *sdp, sector_t sector) > lock_page(page); > > bio = bio_alloc(GFP_NOFS, 1); > - if (unlikely(!bio)) { > - __free_page(page); > - return -ENOBUFS; > - } > - > bio->bi_sector = sector * (sb->s_blocksize >> 9); > bio->bi_bdev = sb->s_bdev; > bio_add_page(bio, page, PAGE_SIZE, 0); >