From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Wed, 10 Jun 2009 11:06:06 +0100
Subject: [Cluster-devel] Re: [PATCH 23/24] GFS2: Fix locking issue mounting
	gfs2meta fs
In-Reply-To: <20090610095319.GC25527@infradead.org>
References: <1244622665-7470-15-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-16-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-17-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-18-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-19-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-20-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-21-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-22-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-23-git-send-email-swhiteho@redhat.com>
	<1244622665-7470-24-git-send-email-swhiteho@redhat.com>
	<20090610095319.GC25527@infradead.org>
Message-ID: <1244628366.3355.9.camel@localhost.localdomain>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On Wed, 2009-06-10 at 05:53 -0400, Christoph Hellwig wrote:
> On Wed, Jun 10, 2009 at 09:31:04AM +0100, Steven Whitehouse wrote:
> >  static struct super_block *get_gfs2_sb(const char *dev_name)
> >  {
> > -	struct super_block *sb;
> 
> Any reason you don't merge get_gfs2_sb into gfs2_get_sb_meta?  That's
> how most other get_sb callbacks are structured, and would also get rid
> of the rather confusing get_gfs2_sb name.
> 

Well originally I was expecting to share that code with the
gfs2_get_sb() but since that patch has been dropped now, I guess there
is no reason not to merge them,

Steve.