From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [PATCH] GFS2: jumping to wrong label?
Date: Mon, 24 Aug 2009 09:55:07 +0100 [thread overview]
Message-ID: <1251104107.3406.1.camel@localhost.localdomain> (raw)
In-Reply-To: <4A902A52.50904@gmail.com>
Hi,
Thanks for spotting & fixing that. Now in the -nmw git tree. Thanks,
Steve.
On Sat, 2009-08-22 at 19:26 +0200, Roel Kluin wrote:
> Also a gfs2_glock_dq() is required here.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I found this by static code analysis, Is it correct? please review.
>
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index f8bd20b..ce551f8 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -349,7 +349,7 @@ static int gfs2_unlink(struct inode *dir, struct dentry *dentry)
>
> error = gfs2_trans_begin(sdp, 2*RES_DINODE + RES_LEAF + RES_RG_BIT, 0);
> if (error)
> - goto out_rgrp;
> + goto out_gunlock;
>
> error = gfs2_dir_del(dip, &dentry->d_name);
> if (error)
parent reply other threads:[~2009-08-24 8:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4A902A52.50904@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251104107.3406.1.camel@localhost.localdomain \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).