* [Cluster-devel] Re: [PATCH] GFS2: jumping to wrong label?
[not found] <4A902A52.50904@gmail.com>
@ 2009-08-24 8:55 ` Steven Whitehouse
0 siblings, 0 replies; only message in thread
From: Steven Whitehouse @ 2009-08-24 8:55 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Thanks for spotting & fixing that. Now in the -nmw git tree. Thanks,
Steve.
On Sat, 2009-08-22 at 19:26 +0200, Roel Kluin wrote:
> Also a gfs2_glock_dq() is required here.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I found this by static code analysis, Is it correct? please review.
>
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index f8bd20b..ce551f8 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -349,7 +349,7 @@ static int gfs2_unlink(struct inode *dir, struct dentry *dentry)
>
> error = gfs2_trans_begin(sdp, 2*RES_DINODE + RES_LEAF + RES_RG_BIT, 0);
> if (error)
> - goto out_rgrp;
> + goto out_gunlock;
>
> error = gfs2_dir_del(dip, &dentry->d_name);
> if (error)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-08-24 8:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4A902A52.50904@gmail.com>
2009-08-24 8:55 ` [Cluster-devel] Re: [PATCH] GFS2: jumping to wrong label? Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).