From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Mon, 12 Oct 2009 10:43:03 +0100 Subject: [Cluster-devel] Re: move gfs2 tracepoints to inclue/trace/events dir In-Reply-To: <20091009234555.GA28257@infradead.org> References: <20091009160115.GA2647@redhat.com> <20091009234555.GA28257@infradead.org> Message-ID: <1255340583.2675.23.camel@localhost.localdomain> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On Fri, 2009-10-09 at 19:45 -0400, Christoph Hellwig wrote: > On Fri, Oct 09, 2009 at 12:01:16PM -0400, Jason Baron wrote: > > hi, > > > > I'd like to move the gfs2 tracepoints to the the common > > include/trace/events directory along with all of the other trace events. > > It makes understanding what tracepoints are available easier, and I see > > no reason why gfs2 should be different. For example, 'ext4.h' is already > > in the include/trace/events directory. > > Folks, no. Drivers and filesystems should be as self-contained as > possible. include/trace/ is an extremly bad idea for everything that's > not actually global kernel functionality. There's a reason all other > fs headers have moved out of include/linux, too. > That true, although there is an argument about how much such a header belongs to tracing and how much it belongs to the subsystem I think. I'll drop the patch from my tree at the next update, until that can be resolved, Steve.