From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/4] GFS2: Fix refcnt leak on gfs2_follow_link() error path
Date: Tue, 2 Feb 2010 09:47:22 +0000 [thread overview]
Message-ID: <1265104045-15957-2-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1265104045-15957-1-git-send-email-swhiteho@redhat.com>
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
If ->follow_link handler return the error, it should decrement
nd->path refcnt.
This patch fix it.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
---
fs/gfs2/ops_inode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
index 78f73ca..84350e1 100644
--- a/fs/gfs2/ops_inode.c
+++ b/fs/gfs2/ops_inode.c
@@ -1088,7 +1088,8 @@ static void *gfs2_follow_link(struct dentry *dentry, struct nameidata *nd)
error = vfs_follow_link(nd, buf);
if (buf != array)
kfree(buf);
- }
+ } else
+ path_put(&nd->path);
return ERR_PTR(error);
}
--
1.6.2.5
next prev parent reply other threads:[~2010-02-02 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 9:47 [Cluster-devel] [GFS2] Pre-pull patch posting (fixes) Steven Whitehouse
2010-02-02 9:47 ` Steven Whitehouse [this message]
2010-02-02 9:47 ` [Cluster-devel] [PATCH 2/4] GFS2: Don't withdraw on partial rindex entries Steven Whitehouse
2010-02-02 9:47 ` [Cluster-devel] [PATCH 3/4] GFS2: Fix previous patch Steven Whitehouse
2010-02-02 9:47 ` [Cluster-devel] [PATCH 4/4] GFS2: Use GFP_NOFS for alloc structure Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265104045-15957-2-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).