cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals
@ 2010-02-05 23:17 Abhijith Das
  0 siblings, 0 replies; 3+ messages in thread
From: Abhijith Das @ 2010-02-05 23:17 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Hi,

We need this one-liner to signal the mount helper of the 'insufficient journals' condition.

Signed-off-by: Abhijith Das <adas@redhat.com>

diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index d405c38..a054b52 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int undo)
 		goto fail;
 	}
 
-	error = -EINVAL;
+	error = -EUSERS;
 	if (!gfs2_jindex_size(sdp)) {
 		fs_err(sdp, "no journals!\n");
 		goto fail_jindex;



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals
       [not found] <1794011848.1142141265412324522.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
@ 2010-02-05 23:25 ` Abhijith Das
  2010-02-08 10:57   ` Steven Whitehouse
  0 siblings, 1 reply; 3+ messages in thread
From: Abhijith Das @ 2010-02-05 23:25 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one.

--Abhi

----- "Abhijith Das" <adas@redhat.com> wrote:

> From: "Abhijith Das" <adas@redhat.com>
> To: "cluster-devel" <cluster-devel@redhat.com>
> Sent: Friday, February 5, 2010 5:17:56 PM GMT -06:00 US/Canada Central
> Subject: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough
> journals
>
> Hi,
> 
> We need this one-liner to signal the mount helper of the 'insufficient
> journals' condition.
> 
> Signed-off-by: Abhijith Das <adas@redhat.com>
> 
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index d405c38..a054b52 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int
> undo)
>  		goto fail;
>  	}
>  
> -	error = -EINVAL;
> +	error = -EUSERS;
>  	if (!gfs2_jindex_size(sdp)) {
>  		fs_err(sdp, "no journals!\n");
>  		goto fail_jindex;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bz537201-kernel-upstream.patch
Type: text/x-patch
Size: 362 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20100205/6553d242/attachment.bin>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals
  2010-02-05 23:25 ` [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals Abhijith Das
@ 2010-02-08 10:57   ` Steven Whitehouse
  0 siblings, 0 replies; 3+ messages in thread
From: Steven Whitehouse @ 2010-02-08 10:57 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

On Fri, 2010-02-05 at 18:25 -0500, Abhijith Das wrote:
> Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one.
> 
> --Abhi
> 
> ----- "Abhijith Das" <adas@redhat.com> wrote:
> 
> > From: "Abhijith Das" <adas@redhat.com>
> > To: "cluster-devel" <cluster-devel@redhat.com>
> > Sent: Friday, February 5, 2010 5:17:56 PM GMT -06:00 US/Canada Central
> > Subject: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough
> > journals
> >
> > Hi,
> > 
> > We need this one-liner to signal the mount helper of the 'insufficient
> > journals' condition.
> > 
> > Signed-off-by: Abhijith Das <adas@redhat.com>
> > 
> > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> > index d405c38..a054b52 100644
> > --- a/fs/gfs2/ops_fstype.c
> > +++ b/fs/gfs2/ops_fstype.c
> > @@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int
> > undo)
> >  		goto fail;
> >  	}
> >  
> > -	error = -EINVAL;
> > +	error = -EUSERS;
> >  	if (!gfs2_jindex_size(sdp)) {
> >  		fs_err(sdp, "no journals!\n");
> >  		goto fail_jindex;




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-02-08 10:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1794011848.1142141265412324522.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2010-02-05 23:25 ` [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals Abhijith Das
2010-02-08 10:57   ` Steven Whitehouse
2010-02-05 23:17 Abhijith Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).