cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/2] dlm: Remove obsolete lockspace lookup
Date: Wed, 17 Feb 2010 09:41:35 +0000	[thread overview]
Message-ID: <1266399695-29885-3-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1266399695-29885-2-git-send-email-swhiteho@redhat.com>

We don't need to look up the lockspace in this particular
case since we already have a pointer to it (which was being
dereferenced in order to do the lookup in the first place).

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
---
 fs/dlm/lockspace.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index 26a8bd4..ce0fdf5 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -37,10 +37,6 @@ static ssize_t dlm_control_store(struct dlm_ls *ls, const char *buf, size_t len)
 	ssize_t ret = len;
 	int n = simple_strtol(buf, NULL, 0);
 
-	ls = dlm_find_lockspace_local(ls->ls_local_handle);
-	if (!ls)
-		return -EINVAL;
-
 	switch (n) {
 	case 0:
 		dlm_ls_stop(ls);
@@ -51,7 +47,7 @@ static ssize_t dlm_control_store(struct dlm_ls *ls, const char *buf, size_t len)
 	default:
 		ret = -EINVAL;
 	}
-	dlm_put_lockspace(ls);
+
 	return ret;
 }
 
-- 
1.6.2.5



  reply	other threads:[~2010-02-17  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17  9:41 [Cluster-devel] [dlm] Two small sysfs patches Steven Whitehouse
2010-02-17  9:41 ` [Cluster-devel] [PATCH 1/2] dlm: Send lockspace name with uevents Steven Whitehouse
2010-02-17  9:41   ` Steven Whitehouse [this message]
2010-02-17 20:12     ` [Cluster-devel] [PATCH 2/2] dlm: Remove obsolete lockspace lookup David Teigland
2010-02-18  9:16       ` Steven Whitehouse
2010-02-18 21:04         ` David Teigland
2010-02-19 11:52           ` Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266399695-29885-3-git-send-email-swhiteho@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).