From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Wed, 12 May 2010 10:30:17 +0100
Subject: [Cluster-devel] [GFS2 Patch] Eliminate useless err variable
In-Reply-To: <1474209843.571171273613734869.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
References: <1474209843.571171273613734869.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
Message-ID: <1273656617.2884.26.camel@localhost>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

Now in the -nmw git tree. Thanks,

Steve.

On Tue, 2010-05-11 at 17:35 -0400, Bob Peterson wrote:
> Hi,
> 
> This patch removes an unneeded "err" variable that is always
> returned as zero.
> 
> Regards,
> 
> Bob Peterson
> Red Hat File Systems
> --
>  fs/gfs2/meta_io.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
> index abafda1..18176d0 100644
> --- a/fs/gfs2/meta_io.c
> +++ b/fs/gfs2/meta_io.c
> @@ -34,7 +34,6 @@
>  
>  static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wbc)
>  {
> -	int err;
>  	struct buffer_head *bh, *head;
>  	int nr_underway = 0;
>  	int write_op = (1 << BIO_RW_META) | ((wbc->sync_mode == WB_SYNC_ALL ?
> @@ -86,11 +85,10 @@ static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wb
>  	} while (bh != head);
>  	unlock_page(page);
>  
> -	err = 0;
>  	if (nr_underway == 0)
>  		end_page_writeback(page);
>  
> -	return err;
> +	return 0;
>  }
>  
>  const struct address_space_operations gfs2_meta_aops = {