* [Cluster-devel] [GFS2 Patch] Eliminate useless err variable
@ 2010-05-11 21:35 Bob Peterson
2010-05-12 9:30 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2010-05-11 21:35 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This patch removes an unneeded "err" variable that is always
returned as zero.
Regards,
Bob Peterson
Red Hat File Systems
--
fs/gfs2/meta_io.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index abafda1..18176d0 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -34,7 +34,6 @@
static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wbc)
{
- int err;
struct buffer_head *bh, *head;
int nr_underway = 0;
int write_op = (1 << BIO_RW_META) | ((wbc->sync_mode == WB_SYNC_ALL ?
@@ -86,11 +85,10 @@ static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wb
} while (bh != head);
unlock_page(page);
- err = 0;
if (nr_underway == 0)
end_page_writeback(page);
- return err;
+ return 0;
}
const struct address_space_operations gfs2_meta_aops = {
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [GFS2 Patch] Eliminate useless err variable
2010-05-11 21:35 [Cluster-devel] [GFS2 Patch] Eliminate useless err variable Bob Peterson
@ 2010-05-12 9:30 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2010-05-12 9:30 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On Tue, 2010-05-11 at 17:35 -0400, Bob Peterson wrote:
> Hi,
>
> This patch removes an unneeded "err" variable that is always
> returned as zero.
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
> --
> fs/gfs2/meta_io.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
> index abafda1..18176d0 100644
> --- a/fs/gfs2/meta_io.c
> +++ b/fs/gfs2/meta_io.c
> @@ -34,7 +34,6 @@
>
> static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wbc)
> {
> - int err;
> struct buffer_head *bh, *head;
> int nr_underway = 0;
> int write_op = (1 << BIO_RW_META) | ((wbc->sync_mode == WB_SYNC_ALL ?
> @@ -86,11 +85,10 @@ static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wb
> } while (bh != head);
> unlock_page(page);
>
> - err = 0;
> if (nr_underway == 0)
> end_page_writeback(page);
>
> - return err;
> + return 0;
> }
>
> const struct address_space_operations gfs2_meta_aops = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-12 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-11 21:35 [Cluster-devel] [GFS2 Patch] Eliminate useless err variable Bob Peterson
2010-05-12 9:30 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).