cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 06/11] GFS2: fix quota state reporting
Date: Mon, 17 May 2010 13:40:20 +0100	[thread overview]
Message-ID: <1274100025-26629-7-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1274100025-26629-6-git-send-email-swhiteho@redhat.com>

From: Christoph Hellwig <hch@lst.de>

We need to report both the accounting and enforcing flags if we are
in enforcing mode.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
---
 fs/gfs2/quota.c |   16 ++++++++++++----
 1 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index 6dbcbad..6ca0967 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -1418,10 +1418,18 @@ static int gfs2_quota_get_xstate(struct super_block *sb,
 
 	memset(fqs, 0, sizeof(struct fs_quota_stat));
 	fqs->qs_version = FS_QSTAT_VERSION;
-	if (sdp->sd_args.ar_quota == GFS2_QUOTA_ON)
-		fqs->qs_flags = (XFS_QUOTA_UDQ_ENFD | XFS_QUOTA_GDQ_ENFD);
-	else if (sdp->sd_args.ar_quota == GFS2_QUOTA_ACCOUNT)
-		fqs->qs_flags = (XFS_QUOTA_UDQ_ACCT | XFS_QUOTA_GDQ_ACCT);
+
+	switch (sdp->sd_args.ar_quota) {
+	case GFS2_QUOTA_ON:
+		fqs->qs_flags |= (XFS_QUOTA_UDQ_ENFD | XFS_QUOTA_GDQ_ENFD);
+		/*FALLTHRU*/
+	case GFS2_QUOTA_ACCOUNT:
+		fqs->qs_flags |= (XFS_QUOTA_UDQ_ACCT | XFS_QUOTA_GDQ_ACCT);
+		break;
+	case GFS2_QUOTA_OFF:
+		break;
+	}
+
 	if (sdp->sd_quota_inode) {
 		fqs->qs_uquota.qfs_ino = GFS2_I(sdp->sd_quota_inode)->i_no_addr;
 		fqs->qs_uquota.qfs_nblks = sdp->sd_quota_inode->i_blocks;
-- 
1.6.2.5



  reply	other threads:[~2010-05-17 12:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-17 12:40 [Cluster-devel] GFS2: Pre-pull patch posting Steven Whitehouse
2010-05-17 12:40 ` [Cluster-devel] [PATCH 01/11] GFS2: Remove space from slab cache name Steven Whitehouse
2010-05-17 12:40   ` [Cluster-devel] [PATCH 02/11] GFS2: docs update Steven Whitehouse
2010-05-17 12:40     ` [Cluster-devel] [PATCH 03/11] GFS2: Clean up stuffed file copying Steven Whitehouse
2010-05-17 12:40       ` [Cluster-devel] [PATCH 04/11] GFS2: glock livelock Steven Whitehouse
2010-05-17 12:40         ` [Cluster-devel] [PATCH 05/11] GFS2: Various gfs2_logd improvements Steven Whitehouse
2010-05-17 12:40           ` Steven Whitehouse [this message]
2010-05-17 12:40             ` [Cluster-devel] [PATCH 07/11] GFS2: Add some useful messages Steven Whitehouse
2010-05-17 12:40               ` [Cluster-devel] [PATCH 08/11] GFS2: Fix writing to non-page aligned gfs2_quota structures Steven Whitehouse
2010-05-17 12:40                 ` [Cluster-devel] [PATCH 09/11] GFS2: Eliminate useless err variable Steven Whitehouse
2010-05-17 12:40                   ` [Cluster-devel] [PATCH 10/11] GFS2: stuck in inode wait, no glocks stuck Steven Whitehouse
2010-05-17 12:40                     ` [Cluster-devel] [PATCH 11/11] GFS2: Fix typo Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274100025-26629-7-git-send-email-swhiteho@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).