From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Mon, 07 Jun 2010 11:18:16 +0100
Subject: [Cluster-devel] [PATCH] gfs2: stop using mpage_writepage
In-Reply-To: <20100607100344.GA1990@lst.de>
References: <20100607100344.GA1990@lst.de>
Message-ID: <1275905896.2449.55.camel@localhost>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On Mon, 2010-06-07 at 12:03 +0200, Christoph Hellwig wrote:
> GFS2 always creates buffer_heads during ->write_begin or ->page_mkwrite,
> which means mpage_writepage always falls back to block_write_full_page.
> 
> So stop calling mpage_writepage and always call block_write_full_page
> directly.
> 
->write_begin does, but I did hope to change that eventually. On the
other hand that isn't true of ->page_mkwrite unless an unstuffing
operation occurs,

Steve.

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/fs/gfs2/aops.c
> ===================================================================
> --- linux-2.6.orig/fs/gfs2/aops.c	2010-06-07 11:22:42.239273013 +0200
> +++ linux-2.6/fs/gfs2/aops.c	2010-06-07 11:23:23.563255580 +0200
> @@ -136,10 +136,7 @@ static int gfs2_writeback_writepage(stru
>  	if (ret <= 0)
>  		return ret;
>  
> -	ret = mpage_writepage(page, gfs2_get_block_noalloc, wbc);
> -	if (ret == -EAGAIN)
> -		ret = block_write_full_page(page, gfs2_get_block_noalloc, wbc);
> -	return ret;
> +	return block_write_full_page(page, gfs2_get_block_noalloc, wbc);
>  }
>  
>  /**