From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 6/8] Revert "GFS2: recovery stuck on transaction lock"
Date: Mon, 2 Aug 2010 10:27:57 +0100 [thread overview]
Message-ID: <1280741279-6782-7-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1280741279-6782-1-git-send-email-swhiteho@redhat.com>
This reverts commit b7dc2df5725fe7355fd76000ead7e39728e1b8a9.
The initial patch didn't quite work since it doesn't cover all
the possible routes by which the GLF_FROZEN flag might be set.
A revised fix is coming up in the next patch.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 717531d..2b3d8f8 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -707,18 +707,8 @@ static void glock_work_func(struct work_struct *work)
{
unsigned long delay = 0;
struct gfs2_glock *gl = container_of(work, struct gfs2_glock, gl_work.work);
- struct gfs2_holder *gh;
int drop_ref = 0;
- if (unlikely(test_bit(GLF_FROZEN, &gl->gl_flags))) {
- spin_lock(&gl->gl_spin);
- gh = find_first_waiter(gl);
- if (gh && (gh->gh_flags & LM_FLAG_NOEXP) &&
- test_and_clear_bit(GLF_FROZEN, &gl->gl_flags))
- set_bit(GLF_REPLY_PENDING, &gl->gl_flags);
- spin_unlock(&gl->gl_spin);
- }
-
if (test_and_clear_bit(GLF_REPLY_PENDING, &gl->gl_flags)) {
finish_xmote(gl, gl->gl_reply);
drop_ref = 1;
--
1.7.1.1
next prev parent reply other threads:[~2010-08-02 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 9:27 [Cluster-devel] GFS2: Pre-pull patch posting Steven Whitehouse
2010-08-02 9:27 ` [Cluster-devel] [PATCH 1/8] GFS2: Use nobh_writepage Steven Whitehouse
2010-08-02 9:27 ` [Cluster-devel] [PATCH 2/8] GFS2: Wait for journal id on mount if not specified on mount command line Steven Whitehouse
2010-08-02 9:27 ` [Cluster-devel] [PATCH 3/8] GFS2: Simplify gfs2_write_alloc_required Steven Whitehouse
2010-08-02 9:27 ` [Cluster-devel] [PATCH 4/8] GFS2: remove dependency on __GFP_NOFAIL Steven Whitehouse
2010-08-02 9:27 ` [Cluster-devel] [PATCH 5/8] GFS2: Make "try" lock not try quite so hard Steven Whitehouse
2010-08-02 9:27 ` Steven Whitehouse [this message]
2010-08-02 9:27 ` [Cluster-devel] [PATCH 7/8] GFS2: Fix typo in stuffed file data copy handling Steven Whitehouse
2010-08-02 9:27 ` [Cluster-devel] [PATCH 8/8] GFS2: Fix recovery stuck bug (try #2) Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280741279-6782-7-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).