cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Pierre Carrier <pcarrier@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Handle multiple filesystems on a single mountpoint
Date: Mon, 23 Aug 2010 13:29:54 +0100	[thread overview]
Message-ID: <1282566595-2300-1-git-send-email-pcarrier@redhat.com> (raw)

Hello,


Here is a patch against gfs1-utils.git

Use-case:
When both a GFS and a GFS2 filesystems are mounted on the same mountpoint,
# umount /example
/sbin/umount.gfs2: /example is not a gfs2 filesystem
/sbin/umount.gfs: /example is not a gfs filesystem
/sbin/umount.gfs2: /example is not a gfs2 filesystem


Best regards,

-- 
Pierre
---
 gfs/gfs_tool/util.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/gfs/gfs_tool/util.c b/gfs/gfs_tool/util.c
index f467b7e..bc9cf50 100644
--- a/gfs/gfs_tool/util.c
+++ b/gfs/gfs_tool/util.c
@@ -123,7 +123,7 @@ mp2cookie(char *mp, int ioctl_ok)
 	char *list, **lines;
 	FILE *file;
 	char line[256], device[256], dev_id[256];
-	unsigned int x;
+	unsigned int x, non_gfs_found = 0;
 	struct stat st;
 
 	cookie = malloc(256);
@@ -145,8 +145,10 @@ mp2cookie(char *mp, int ioctl_ok)
 			continue;
 		if (strcmp(path, mp))
 			continue;
-		if (strcmp(type, "gfs"))
-			die("%s is not a GFS filesystem\n", mp);
+		if (strcmp(type, "gfs")) {
+			non_gfs_found++;
+			continue;
+		}
 
 		if (stat(device, &st))
 			continue;
@@ -154,6 +156,9 @@ mp2cookie(char *mp, int ioctl_ok)
 		break;
 	}
 
+	if(!dev_id[0] && non_gfs_found)
+		die("Only %u non-GFS filesystems are mounted on %s\n", non_gfs_found, mp);
+
 	fclose(file);
 
 	for (x = 0; *lines[x]; x++) {
-- 
1.7.2.1



             reply	other threads:[~2010-08-23 12:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 12:29 Pierre Carrier [this message]
2010-08-23 12:29 ` [Cluster-devel] [PATCH] Handle multiple filesystems on a single mountpoint Pierre Carrier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282566595-2300-1-git-send-email-pcarrier@redhat.com \
    --to=pcarrier@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).