From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 14/22] GFS2: Fix journal check for spectator mounts
Date: Mon, 18 Oct 2010 15:15:38 +0100 [thread overview]
Message-ID: <1287411346-17855-15-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1287411346-17855-1-git-send-email-swhiteho@redhat.com>
When checking journals for spectator mounts, we cannot rely on the
journal being locked, whatever its jid might be. This patch
ensures that we always get the journal locks when checking
journals for a spectator mount.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
index f7f89a9..666548e 100644
--- a/fs/gfs2/recovery.c
+++ b/fs/gfs2/recovery.c
@@ -456,7 +456,8 @@ void gfs2_recover_func(struct work_struct *work)
unsigned int pass;
int error;
- if (jd->jd_jid != sdp->sd_lockstruct.ls_jid) {
+ if (sdp->sd_args.ar_spectator ||
+ (jd->jd_jid != sdp->sd_lockstruct.ls_jid)) {
fs_info(sdp, "jid=%u: Trying to acquire journal lock...\n",
jd->jd_jid);
--
1.7.1.1
next prev parent reply other threads:[~2010-10-18 14:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 14:15 [Cluster-devel] GFS2: Pre-pull patch posting Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 01/22] GFS2: New truncate sequence Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 02/22] GFS2: Remove i_disksize Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 03/22] GFS2: No longer experimental Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 04/22] GFS2: Add a bug trap in allocation code Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 05/22] GFS2: fallocate support Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 06/22] GFS2: Fix whitespace in previous patch Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 07/22] GFS2: Don't enforce min hold time when two demotes occur in rapid succession Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 08/22] GFS2: Update handling of DLM return codes to match reality Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 09/22] GFS2: Use new workqueue scheme Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 10/22] GFS2: Make . and .. qstrs constant Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 11/22] GFS2: Remove ignore_local_fs mount argument Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 12/22] GFS2: Remove localcaching mount option Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 13/22] GFS2: Remove upgrade " Steven Whitehouse
2010-10-18 14:15 ` Steven Whitehouse [this message]
2010-10-18 14:15 ` [Cluster-devel] [PATCH 15/22] GFS2: reserve more blocks for transactions Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 16/22] GFS2: Fix compiler warning from previous patch Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 17/22] GFS2: Fix spectator umount issue Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 18/22] GFS2: Add "norecovery" mount option as a synonym for "spectator" Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 19/22] GFS2: Improve journal allocation via sysfs Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 20/22] GFS2 fatal: filesystem consistency error on rename Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 21/22] GFS2: Fix type mapping for demote_rq interface Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 22/22] GFS2: fixed typo Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287411346-17855-15-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).