cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 21/22] GFS2: Fix type mapping for demote_rq interface
Date: Mon, 18 Oct 2010 15:15:45 +0100	[thread overview]
Message-ID: <1287411346-17855-22-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1287411346-17855-1-git-send-email-swhiteho@redhat.com>

Mostly the glock operations follow the type of the glock. The
one exception is the transaction glock, so we need to check for
that directly.

Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index 621d80e..0d149dc 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -452,7 +452,6 @@ const struct gfs2_glock_operations *gfs2_glops_list[] = {
 	[LM_TYPE_META] = &gfs2_meta_glops,
 	[LM_TYPE_INODE] = &gfs2_inode_glops,
 	[LM_TYPE_RGRP] = &gfs2_rgrp_glops,
-	[LM_TYPE_NONDISK] = &gfs2_trans_glops,
 	[LM_TYPE_IOPEN] = &gfs2_iopen_glops,
 	[LM_TYPE_FLOCK] = &gfs2_flock_glops,
 	[LM_TYPE_NONDISK] = &gfs2_nondisk_glops,
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index 64082a5..748ccb5 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -230,7 +230,10 @@ static ssize_t demote_rq_store(struct gfs2_sbd *sdp, const char *buf, size_t len
 
 	if (gltype > LM_TYPE_JOURNAL)
 		return -EINVAL;
-	glops = gfs2_glops_list[gltype];
+	if (gltype == LM_TYPE_NONDISK && glnum == GFS2_TRANS_LOCK)
+		glops = &gfs2_trans_glops;
+	else
+		glops = gfs2_glops_list[gltype];
 	if (glops == NULL)
 		return -EINVAL;
 	if (!test_and_set_bit(SDF_DEMOTE, &sdp->sd_flags))
-- 
1.7.1.1



  parent reply	other threads:[~2010-10-18 14:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-18 14:15 [Cluster-devel] GFS2: Pre-pull patch posting Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 01/22] GFS2: New truncate sequence Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 02/22] GFS2: Remove i_disksize Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 03/22] GFS2: No longer experimental Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 04/22] GFS2: Add a bug trap in allocation code Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 05/22] GFS2: fallocate support Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 06/22] GFS2: Fix whitespace in previous patch Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 07/22] GFS2: Don't enforce min hold time when two demotes occur in rapid succession Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 08/22] GFS2: Update handling of DLM return codes to match reality Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 09/22] GFS2: Use new workqueue scheme Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 10/22] GFS2: Make . and .. qstrs constant Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 11/22] GFS2: Remove ignore_local_fs mount argument Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 12/22] GFS2: Remove localcaching mount option Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 13/22] GFS2: Remove upgrade " Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 14/22] GFS2: Fix journal check for spectator mounts Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 15/22] GFS2: reserve more blocks for transactions Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 16/22] GFS2: Fix compiler warning from previous patch Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 17/22] GFS2: Fix spectator umount issue Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 18/22] GFS2: Add "norecovery" mount option as a synonym for "spectator" Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 19/22] GFS2: Improve journal allocation via sysfs Steven Whitehouse
2010-10-18 14:15 ` [Cluster-devel] [PATCH 20/22] GFS2 fatal: filesystem consistency error on rename Steven Whitehouse
2010-10-18 14:15 ` Steven Whitehouse [this message]
2010-10-18 14:15 ` [Cluster-devel] [PATCH 22/22] GFS2: fixed typo Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287411346-17855-22-git-send-email-swhiteho@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).