From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Wed, 10 Nov 2010 13:19:06 -0800 Subject: [Cluster-devel] [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf, 2, 3)) to gfs2_print_dbg In-Reply-To: <1289422527.2438.20.camel@dolmen> References: <5918196ac71b4e3184a534643cdf499b54416541.1289348757.git.joe@perches.com> <1289422527.2438.20.camel@dolmen> Message-ID: <1289423946.15905.103.camel@Joe-Laptop> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Functions that use printf formatting, especially those that use %pV, should have their uses of printf format and arguments checked by the compiler. Signed-off-by: Joe Perches --- No current uses report any error in an allyesconfig build. fs/gfs2/glock.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h index db1c26d..a12d117 100644 --- a/fs/gfs2/glock.h +++ b/fs/gfs2/glock.h @@ -212,6 +212,8 @@ int gfs2_glock_nq_num(struct gfs2_sbd *sdp, int gfs2_glock_nq_m(unsigned int num_gh, struct gfs2_holder *ghs); void gfs2_glock_dq_m(unsigned int num_gh, struct gfs2_holder *ghs); void gfs2_glock_dq_uninit_m(unsigned int num_gh, struct gfs2_holder *ghs); + +__attribute__ ((format(printf, 2, 3))) void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...); /**