cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] dlm: Fix comment in dlm.h regarding lock_dlm() return values
Date: Tue, 23 Nov 2010 13:21:41 +0000	[thread overview]
Message-ID: <1290518501.2423.8.camel@dolmen> (raw)


The code in dlm_lock() explicitly tests for a return value of
-EAGAIN and changes it to zero in that case, so this function
can never return -EAGAIN. I'm not 100% sure that it can
return -ENOTCONN either, but the code paths are more tricky
to trace in that case, so I've left that one for now.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/include/linux/dlm.h b/include/linux/dlm.h
index d4e02f5..3b4236c 100644
--- a/include/linux/dlm.h
+++ b/include/linux/dlm.h
@@ -112,7 +112,6 @@ int dlm_release_lockspace(dlm_lockspace_t *lockspace, int force);
  * Returns:
  * 0 if request is successfully queued for processing
  * -EINVAL if any input parameters are invalid
- * -EAGAIN if request would block and is flagged DLM_LKF_NOQUEUE
  * -ENOMEM if there is no memory to process request
  * -ENOTCONN if there is a communication error
  *




                 reply	other threads:[~2010-11-23 13:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290518501.2423.8.camel@dolmen \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).