From: Lon Hohberger <lhh@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/8] Add "service" object manipulations
Date: Fri, 10 Dec 2010 09:49:08 -0500 [thread overview]
Message-ID: <1291992548.7139.8.camel@localhost.localdomain> (raw)
In-Reply-To: <1291988557-22348-2-git-send-email-dim@parallels.com>
On Fri, 2010-12-10 at 16:42 +0300, Dmitry Mishin wrote:
> +static xmlNode *find_ip_resource(xmlNode *root, const char *name)
> +{
> + return do_find_node(root, name, "ip", "name");
> +}
> +
should be
return do_find_node(root, name, "ip", "address");
IP resources don't have names; the primary attribute is the address
field. Adding a "name" will break configuration validation without
patches to ip.sh and cluster.rng.
(this might happen in other patches too)
-- Lon
next prev parent reply other threads:[~2010-12-10 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 13:42 [Cluster-devel] [PATCH 0/8] [STABLE31] sccs_tool enhancement Dmitry Mishin
2010-12-10 13:42 ` [Cluster-devel] [PATCH 1/8] Add "service" object manipulations Dmitry Mishin
2010-12-10 14:49 ` Lon Hohberger [this message]
2010-12-10 14:51 ` Lon Hohberger
2010-12-10 13:42 ` [Cluster-devel] [PATCH 2/8] Unify 'del' functions Dmitry Mishin
2010-12-10 13:42 ` [Cluster-devel] [PATCH 3/8] Add "script" object manipulations Dmitry Mishin
2010-12-10 13:42 ` [Cluster-devel] [PATCH 4/8] Unify parsing of options Dmitry Mishin
2010-12-10 13:42 ` [Cluster-devel] [PATCH 5/8] Added "ip" object manipulations Dmitry Mishin
2010-12-10 13:42 ` [Cluster-devel] [PATCH 6/8] Added 'fs' " Dmitry Mishin
2010-12-10 13:42 ` [Cluster-devel] [PATCH 7/8] Added 'failoverdomain' " Dmitry Mishin
2010-12-10 13:42 ` [Cluster-devel] [PATCH 8/8] Added ability to reference domains from services Dmitry Mishin
2010-12-10 14:17 ` [Cluster-devel] [PATCH 0/8] [STABLE31] sccs_tool enhancement Fabio M. Di Nitto
2010-12-15 8:06 ` Fabio M. Di Nitto
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 9:00 [Cluster-devel] [PATCH 0/8] ccs_tool enhancement Dmitry Mishin
2010-12-10 9:00 ` [Cluster-devel] [PATCH 1/8] Add "service" object manipulations Dmitry Mishin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291992548.7139.8.camel@localhost.localdomain \
--to=lhh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).