From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lon Hohberger <lhh@redhat.com>
Date: Fri, 10 Dec 2010 09:51:24 -0500
Subject: [Cluster-devel] [PATCH 1/8] Add "service" object manipulations
In-Reply-To: <1291992548.7139.8.camel@localhost.localdomain>
References: <1291988557-22348-1-git-send-email-dim@parallels.com>
	<1291988557-22348-2-git-send-email-dim@parallels.com>
	<1291992548.7139.8.camel@localhost.localdomain>
Message-ID: <1291992684.7139.9.camel@localhost.localdomain>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Fri, 2010-12-10 at 09:49 -0500, Lon Hohberger wrote:
> On Fri, 2010-12-10 at 16:42 +0300, Dmitry Mishin wrote:
> > +static xmlNode *find_ip_resource(xmlNode *root, const char *name)
> > +{
> > +	return do_find_node(root, name, "ip", "name");
> > +}
> > +
> 
> should be
> 
> 	return do_find_node(root, name, "ip", "address");
> 
> IP resources don't have names; the primary attribute is the address
> field.  Adding a "name" will break configuration validation without
> patches to ip.sh and cluster.rng.
> 
> (this might happen in other patches too)

Scratch that, you fixed it in patch 5.

-- Lon