cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 05/15] GFS2: fs/gfs2/glock.c: Use printf extension %pV
Date: Fri, 17 Dec 2010 12:24:11 +0000	[thread overview]
Message-ID: <1292588661-14350-6-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1292588661-14350-1-git-send-email-swhiteho@redhat.com>

From: Joe Perches <joe@perches.com>

Using %pV reduces the number of printk calls and
eliminates any possible message interleaving from
other printk calls.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 13155f6..a9b53a4 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -951,17 +951,22 @@ int gfs2_glock_wait(struct gfs2_holder *gh)
 
 void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...)
 {
+	struct va_format vaf;
 	va_list args;
 
 	va_start(args, fmt);
+
 	if (seq) {
 		struct gfs2_glock_iter *gi = seq->private;
 		vsprintf(gi->string, fmt, args);
 		seq_printf(seq, gi->string);
 	} else {
-		printk(KERN_ERR " ");
-		vprintk(fmt, args);
+		vaf.fmt = fmt;
+		vaf.va = &args;
+
+		printk(KERN_ERR " %pV", &vaf);
 	}
+
 	va_end(args);
 }
 
-- 
1.7.3.3



  parent reply	other threads:[~2010-12-17 12:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-17 12:24 [Cluster-devel] GFS2: Pre-pull patch posting (-nmw) Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 01/15] GFS2: Change two WQ_RESCUERs into WQ_MEM_RECLAIM Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 02/15] GFS2: fs/gfs2/glock.c: Convert sprintf_symbol to %pS Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 03/15] GFS2: Remove unreachable calls to vmtruncate Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 04/15] GFS2: Clean up duplicated setattr code Steven Whitehouse
2010-12-17 12:24 ` Steven Whitehouse [this message]
2010-12-17 12:24 ` [Cluster-devel] [PATCH 06/15] GFS2: fs/gfs2/glock.h: Add __attribute__((format(printf, 2, 3)) to gfs2_print_dbg Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 07/15] GFS2: Allow gfs2 to update quota usage values through the quotactl interface Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 08/15] GFS2: Clean up of gdlm_lock function Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 09/15] GFS2: Remove duplicate #defines from glock.h Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 10/15] GFS2: reread rindex when necessary to grow rindex Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 11/15] GFS2: fix recursive locking during rindex truncates Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 12/15] GFS2: Fix uninitialised error value in previous patch Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 13/15] GFS2: Merge glock state fields into a bitfield Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 14/15] GFS2: fsck.gfs2 reported statfs error after gfs2_grow Steven Whitehouse
2010-12-17 12:24 ` [Cluster-devel] [PATCH 15/15] GFS2: Don't flush delete workqueue when releasing the transaction lock Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292588661-14350-6-git-send-email-swhiteho@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).