* [Cluster-devel] [GFS2 Patch] GFS2: write_end error path fails to unlock transaction lock [not found] <1567195545.477592.1300307424601.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> @ 2011-03-16 20:32 ` Bob Peterson 2011-03-17 11:46 ` Steven Whitehouse 0 siblings, 1 reply; 2+ messages in thread From: Bob Peterson @ 2011-03-16 20:32 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, I did an audit of gfs2's transaction glock for bugzilla bug 658619 and ran across this: In function gfs2_write_end, in the unlikely event that gfs2_meta_inode_buffer returns an error, the code may forget to unlock the transaction lock because the "failed" label appears after the call to function gfs2_trans_end. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson <rpeterso@redhat.com> -- fs/gfs2/aops.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index aad77e4..86870b3 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -884,8 +884,8 @@ static int gfs2_write_end(struct file *file, struct address_space *mapping, } brelse(dibh); - gfs2_trans_end(sdp); failed: + gfs2_trans_end(sdp); if (al) { gfs2_inplace_release(ip); gfs2_quota_unlock(ip); ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [GFS2 Patch] GFS2: write_end error path fails to unlock transaction lock 2011-03-16 20:32 ` [Cluster-devel] [GFS2 Patch] GFS2: write_end error path fails to unlock transaction lock Bob Peterson @ 2011-03-17 11:46 ` Steven Whitehouse 0 siblings, 0 replies; 2+ messages in thread From: Steven Whitehouse @ 2011-03-17 11:46 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, Good spotting, now in the -fixes tree. Thanks, Steve. On Wed, 2011-03-16 at 16:32 -0400, Bob Peterson wrote: > Hi, > > I did an audit of gfs2's transaction glock for bugzilla bug > 658619 and ran across this: > > In function gfs2_write_end, in the unlikely event that > gfs2_meta_inode_buffer returns an error, the code may forget > to unlock the transaction lock because the "failed" label > appears after the call to function gfs2_trans_end. > > Regards, > > Bob Peterson > Red Hat File Systems > > Signed-off-by: Bob Peterson <rpeterso@redhat.com> > -- > fs/gfs2/aops.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c > index aad77e4..86870b3 100644 > --- a/fs/gfs2/aops.c > +++ b/fs/gfs2/aops.c > @@ -884,8 +884,8 @@ static int gfs2_write_end(struct file *file, struct address_space *mapping, > } > > brelse(dibh); > - gfs2_trans_end(sdp); > failed: > + gfs2_trans_end(sdp); > if (al) { > gfs2_inplace_release(ip); > gfs2_quota_unlock(ip); > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-17 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1567195545.477592.1300307424601.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2011-03-16 20:32 ` [Cluster-devel] [GFS2 Patch] GFS2: write_end error path fails to unlock transaction lock Bob Peterson
2011-03-17 11:46 ` Steven Whitehouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).