* [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig
@ 2011-01-03 18:19 Lon Hohberger
2011-01-04 9:00 ` Jan Friesse
0 siblings, 1 reply; 5+ messages in thread
From: Lon Hohberger @ 2011-01-03 18:19 UTC (permalink / raw)
To: cluster-devel.redhat.com
Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
cman/daemon/cman-preconfig.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
index 5239d89..5d608a7 100644
--- a/cman/daemon/cman-preconfig.c
+++ b/cman/daemon/cman-preconfig.c
@@ -286,7 +286,7 @@ static int add_ifaddr(struct objdb_iface_ver0 *objdb, char *mcast, char *ifaddr,
int ret = 0;
const char *tx_mech_to_str[] = {
[TX_MECH_UDP] = "udp",
- [TX_MECH_UDPB] = "udp",
+ [TX_MECH_UDPB] = "udpb",
[TX_MECH_UDPU] = "udpu",
[TX_MECH_RDMA] = "iba",
};
--
1.7.2.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig
2011-01-03 18:19 [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig Lon Hohberger
@ 2011-01-04 9:00 ` Jan Friesse
2011-01-04 9:05 ` Fabio M. Di Nitto
2011-01-04 20:06 ` Lon Hohberger
0 siblings, 2 replies; 5+ messages in thread
From: Jan Friesse @ 2011-01-04 9:00 UTC (permalink / raw)
To: cluster-devel.redhat.com
Lon,
even it may "logically" seemed that original code is incorrect and your
patch make sense, it's not the case.
Actually, corosync has 3 transports:
udp, udpu and iba.
Broadcast is same transport as udp but only has broadcast flag set on.
In other words, this patch is not correct.
Regards,
Honza
Lon Hohberger wrote:
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
> cman/daemon/cman-preconfig.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
> index 5239d89..5d608a7 100644
> --- a/cman/daemon/cman-preconfig.c
> +++ b/cman/daemon/cman-preconfig.c
> @@ -286,7 +286,7 @@ static int add_ifaddr(struct objdb_iface_ver0 *objdb, char *mcast, char *ifaddr,
> int ret = 0;
> const char *tx_mech_to_str[] = {
> [TX_MECH_UDP] = "udp",
> - [TX_MECH_UDPB] = "udp",
> + [TX_MECH_UDPB] = "udpb",
> [TX_MECH_UDPU] = "udpu",
> [TX_MECH_RDMA] = "iba",
> };
^ permalink raw reply [flat|nested] 5+ messages in thread* [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig
2011-01-04 9:00 ` Jan Friesse
@ 2011-01-04 9:05 ` Fabio M. Di Nitto
2011-01-04 9:18 ` Jan Friesse
2011-01-04 20:06 ` Lon Hohberger
1 sibling, 1 reply; 5+ messages in thread
From: Fabio M. Di Nitto @ 2011-01-04 9:05 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 1/4/2011 10:00 AM, Jan Friesse wrote:
> Lon,
> even it may "logically" seemed that original code is incorrect and your
> patch make sense, it's not the case.
>
> Actually, corosync has 3 transports:
> udp, udpu and iba.
>
> Broadcast is same transport as udp but only has broadcast flag set on.
>
> In other words, this patch is not correct.
>
So in order to configure broadcast we still need to use:
<cman transport="udp" broadcast="yes"/> ?
I find that redundant tho...
Cheers
Fabio
> Regards,
> Honza
>
> Lon Hohberger wrote:
>> Signed-off-by: Lon Hohberger <lhh@redhat.com>
>> ---
>> cman/daemon/cman-preconfig.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
>> index 5239d89..5d608a7 100644
>> --- a/cman/daemon/cman-preconfig.c
>> +++ b/cman/daemon/cman-preconfig.c
>> @@ -286,7 +286,7 @@ static int add_ifaddr(struct objdb_iface_ver0 *objdb, char *mcast, char *ifaddr,
>> int ret = 0;
>> const char *tx_mech_to_str[] = {
>> [TX_MECH_UDP] = "udp",
>> - [TX_MECH_UDPB] = "udp",
>> + [TX_MECH_UDPB] = "udpb",
>> [TX_MECH_UDPU] = "udpu",
>> [TX_MECH_RDMA] = "iba",
>> };
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig
2011-01-04 9:05 ` Fabio M. Di Nitto
@ 2011-01-04 9:18 ` Jan Friesse
0 siblings, 0 replies; 5+ messages in thread
From: Jan Friesse @ 2011-01-04 9:18 UTC (permalink / raw)
To: cluster-devel.redhat.com
Fabio M. Di Nitto wrote:
> On 1/4/2011 10:00 AM, Jan Friesse wrote:
>> Lon,
>> even it may "logically" seemed that original code is incorrect and your
>> patch make sense, it's not the case.
>>
>> Actually, corosync has 3 transports:
>> udp, udpu and iba.
>>
>> Broadcast is same transport as udp but only has broadcast flag set on.
>>
>> In other words, this patch is not correct.
>>
>
> So in order to configure broadcast we still need to use:
>
> <cman transport="udp" broadcast="yes"/> ?
>
> I find that redundant tho...
>
> Cheers
> Fabio
>
No.
Actually. Original idea was to use transport keyword and give user
ability to use udp (for multicast), udpu (for unicast), udpb (for
broadcast) and rdma. But also we must keep compatibility so thats why
broadcast keyword still exists. So actually, transport="udpb" is same as
transport="udp" broadcast="yes".
Regards,
Honza
>> Regards,
>> Honza
>>
>> Lon Hohberger wrote:
>>> Signed-off-by: Lon Hohberger <lhh@redhat.com>
>>> ---
>>> cman/daemon/cman-preconfig.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
>>> index 5239d89..5d608a7 100644
>>> --- a/cman/daemon/cman-preconfig.c
>>> +++ b/cman/daemon/cman-preconfig.c
>>> @@ -286,7 +286,7 @@ static int add_ifaddr(struct objdb_iface_ver0 *objdb, char *mcast, char *ifaddr,
>>> int ret = 0;
>>> const char *tx_mech_to_str[] = {
>>> [TX_MECH_UDP] = "udp",
>>> - [TX_MECH_UDPB] = "udp",
>>> + [TX_MECH_UDPB] = "udpb",
>>> [TX_MECH_UDPU] = "udpu",
>>> [TX_MECH_RDMA] = "iba",
>>> };
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig
2011-01-04 9:00 ` Jan Friesse
2011-01-04 9:05 ` Fabio M. Di Nitto
@ 2011-01-04 20:06 ` Lon Hohberger
1 sibling, 0 replies; 5+ messages in thread
From: Lon Hohberger @ 2011-01-04 20:06 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Tue, 2011-01-04 at 10:00 +0100, Jan Friesse wrote:
> Lon,
> even it may "logically" seemed that original code is incorrect and your
> patch make sense, it's not the case.
>
> Actually, corosync has 3 transports:
> udp, udpu and iba.
>
> Broadcast is same transport as udp but only has broadcast flag set on.
>
> In other words, this patch is not correct.
Ok, reverted. Sorry for clouding the issue,
-- Lon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-04 20:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-03 18:19 [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig Lon Hohberger
2011-01-04 9:00 ` Jan Friesse
2011-01-04 9:05 ` Fabio M. Di Nitto
2011-01-04 9:18 ` Jan Friesse
2011-01-04 20:06 ` Lon Hohberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).