cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory
Date: Wed, 23 Mar 2011 14:04:36 +0000	[thread overview]
Message-ID: <1300889076.2590.46.camel@dolmen> (raw)
In-Reply-To: <644917506.564682.1300888545934.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>

Hi,

On Wed, 2011-03-23 at 09:55 -0400, Bob Peterson wrote:
> ----- Original Message -----
> | Hi,
> | 
> | We still need that, it is the generation number for NFS. Although it
> | is
> | also identical to the no_formal_ino in recent kernels,
> | 
> | Steve.
> 
> Are you saying that nfs manipulates gfs2's i_generation value in
> the incore gfs2_inode structure?  If so, that scares me; there
> should be an interface to do that.  If not, it must be for some
> future development, because we don't reference the value anywhere.
> 
> Regards,
> 
> Bob Peterson
> Red Hat File Systems

It is identical to the no_formal_ino in all recent kernels and we use
that value for NFS generation number purposes. Really we should be using
this value and not the no_formal_ino one, but the switch didn't get made
when the original change was made. Both values are identical, except for
very old versions of the code. I think we should retain this field
though, since it can be useful for debugging,

Steve.




      reply	other threads:[~2011-03-23 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 13:37 [Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory Bob Peterson
2011-03-23 13:50 ` Steven Whitehouse
2011-03-23 13:55   ` Bob Peterson
2011-03-23 14:04     ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300889076.2590.46.camel@dolmen \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).