From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] GFS2: Inode/link count patch set
Date: Mon, 9 May 2011 17:32:21 +0100 [thread overview]
Message-ID: <1304958749-15194-1-git-send-email-swhiteho@redhat.com> (raw)
Hi,
Here are a bunch of patches designed to clean up the way in which
GFS2 deals with link counts and to unify the inode code. The major
features are:
o Approx 200 lines of code less after these patches
o Merged rmdir and unlink code (since it was nearly identical anyway)
o Cleaned up link count handling for mkdir/rmdir
o All inode code is in inode.c after this patch set
(inode.c code is moved to various places, ops_inode.c is renamed as
inode.c)
I've done a bit of testing with ln, mv, touch, mkdir, rmdir etc and so
far it seems to be holding up ok. I've been checking the link counts
at each step to ensure that they are correct and so far that looks good
too.
It should be easier to understand the code after this change since we now
update the link counts of directories at the point at which subdirectory
names are added and removed from them, rather than doing it as a separate
operation as we used to do. So it should be more efficient from a cpu
time PoV, although I've not tried to measure that yet.
Steve.
next reply other threads:[~2011-05-09 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 16:32 Steven Whitehouse [this message]
2011-05-09 16:32 ` [Cluster-devel] [PATCH 1/8] GFS2: Don't use gfs2_change_nlink in link syscall Steven Whitehouse
2011-05-09 16:32 ` [Cluster-devel] [PATCH 2/8] GFS2: Make gfs2_dir_del update link count when required Steven Whitehouse
2011-05-09 16:32 ` [Cluster-devel] [PATCH 3/8] GFS2: When adding a new dir entry, inc link count if it is a subdir Steven Whitehouse
2011-05-09 16:32 ` [Cluster-devel] [PATCH 4/8] GFS2: Remove gfs2_dinode_print() function Steven Whitehouse
2011-05-09 16:32 ` [Cluster-devel] [PATCH 5/8] GFS2: Move gfs2_refresh_inode() and friends into glops.c Steven Whitehouse
2011-05-09 16:32 ` [Cluster-devel] [PATCH 6/8] GFS2: Move most of the remaining inode.c into ops_inode.c Steven Whitehouse
2011-05-09 16:32 ` [Cluster-devel] [PATCH 7/8] GFS2: Move final part of inode.c into super.c Steven Whitehouse
2011-05-09 16:32 ` [Cluster-devel] [PATCH 8/8] GFS2: Remove inode.c and rename ops_inode.c to inode.c Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304958749-15194-1-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).