From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Fri, 22 Jul 2011 09:34:08 +0100
Subject: [Cluster-devel] tunegfs2: Fix label/locktable setting code
In-Reply-To: <4E2806D9.3000403@redhat.com>
References: <1311155869.2703.8.camel@menhir>  <4E2806D9.3000403@redhat.com>
Message-ID: <1311323648.2804.4.camel@menhir>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On Thu, 2011-07-21 at 12:00 +0100, Andrew Price wrote:
> Hi Steve,
> 
> On 20/07/11 10:57, Steven Whitehouse wrote:
> >
> > This is an updated version of the previously posted patch aimed at
> > fixing bz #719135
> 
> Looks good to me. Just a couple of minor notes on input validation...
> 
> With this patch it's possible to set the locktable to ":" using:
> 
> # tunegfs2 -o lockproto=lock_dlm /dev/dm-3
> # tunegfs2 -L : /dev/dm-3
> 
> And although this rightly fails:
> 
> # tunegfs2 -o lockproto=lock_dlm,locktable=foo /dev/dm-3
> locktable error: mising colon in the locktable
> 
> it is still possible to specify a colon-less locktable name with lock_dlm:
> 
> # tunegfs2 -o lockproto=lock_nolock /dev/dm-3
> # tunegfs2 -L foo /dev/dm-3
> # tunegfs2 -o lockproto=lock_dlm /dev/dm-3
> 
Yes, I'm not overly worried by that. Mounting will fail so it is still
impossible to cause a problem by doing that, I think,

Steve.