From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] mount.gfs2 - gfs2 mounts doubled up in mtab
Date: Fri, 22 Jul 2011 09:35:53 +0100 [thread overview]
Message-ID: <1311323753.2804.5.camel@menhir> (raw)
In-Reply-To: <280913532.167648.1311192646977.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Hi,
On Wed, 2011-07-20 at 16:10 -0400, Abhijith Das wrote:
> When the -o remount option is used with mount.gfs2 it fails to remove the original mtab entry because it can't find it. Instead it simply adds the mount entry corresponding to the remount, thereby doubling the entries in mtab. This patch corrects the logic to find the mtab entry so mount.gfs2 finds and removes the original entry correctly before add the the remount entry.
>
> Signed-off-by: Abhi Das <adas@redhat.com>
+ sscanf(line, "%s %s %s", device, path, type);
This seems to remove the error checking for argument assignment from
sscanf,
Steve.
next prev parent reply other threads:[~2011-07-22 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201524563.167642.1311192642732.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2011-07-20 20:10 ` [Cluster-devel] [PATCH] mount.gfs2 - gfs2 mounts doubled up in mtab Abhijith Das
2011-07-22 8:35 ` Steven Whitehouse [this message]
2011-07-22 14:11 ` Abhijith Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311323753.2804.5.camel@menhir \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).