From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/2] cman: Print an error if cluster name is too long
Date: Fri, 5 Aug 2011 10:08:56 +0200 [thread overview]
Message-ID: <1312531737-27061-1-git-send-email-fdinitto@redhat.com> (raw)
From: Christine Caulfield <ccaulfie@redhat.com>
Print an error and exit cman-preconfig if the cluster name
exceeeds 15 characters.
Resolvs: rhbz#728230
Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>
---
cman/daemon/cman-preconfig.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
index aeedf8b..e435484 100644
--- a/cman/daemon/cman-preconfig.c
+++ b/cman/daemon/cman-preconfig.c
@@ -1274,6 +1274,10 @@ static int get_cman_globals(struct objdb_iface_ver0 *objdb)
char *use_hash;
objdb_get_string(objdb, cluster_parent_handle, "name", &cluster_name);
+ if (!cluster_name || strlen(cluster_name) > 15) {
+ sprintf(error_reason, "%s\n", "Invalid cluster name. It must be 15 characters or fewer\n");
+ return -1;
+ }
if (!cluster_name) {
sprintf(error_reason, "Unable to determine cluster name.\n");
--
1.7.4.4
next reply other threads:[~2011-08-05 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 8:08 Fabio M. Di Nitto [this message]
2011-08-05 8:08 ` [Cluster-devel] [PATCH 2/2] cman: fix printing of error if clustername is too long Fabio M. Di Nitto
2011-08-05 8:30 ` Christine Caulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312531737-27061-1-git-send-email-fdinitto@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).