cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [Patch 07/44] fsck.gfs2: Rename function check_leaf to check_ealeaf_block
Date: Fri, 12 Aug 2011 10:18:28 +0100	[thread overview]
Message-ID: <1313140708.2704.23.camel@menhir> (raw)
In-Reply-To: <2062834442.544642.1313096433458.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>

This is another trivial one that could be pushed right away I think,

Steve.

On Thu, 2011-08-11 at 17:00 -0400, Bob Peterson wrote:
> >From a2fc75cad03602f8582a744c6a14ddae3a85cffd Mon Sep 17 00:00:00 2001
> From: Bob Peterson <rpeterso@redhat.com>
> Date: Mon, 8 Aug 2011 12:58:04 -0500
> Subject: [PATCH 07/44] fsck.gfs2: Rename function check_leaf to
>  check_ealeaf_block
> 
> This patch renames function check_leaf_block to check_ealeaf_block to
> avoid confusion between directory leaf block handling and extended
> attribute leaf block handling.
> 
> rhbz#675723
> ---
>  gfs2/fsck/pass1.c |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/gfs2/fsck/pass1.c b/gfs2/fsck/pass1.c
> index e2fe73c..30d6b3c 100644
> --- a/gfs2/fsck/pass1.c
> +++ b/gfs2/fsck/pass1.c
> @@ -636,8 +636,11 @@ static int finish_eattr_indir(struct gfs2_inode *ip, int leaf_pointers,
>  	return 1;
>  }
>  
> -static int check_leaf_block(struct gfs2_inode *ip, uint64_t block, int btype,
> -			    struct gfs2_buffer_head **bh, void *private)
> +/* check_ealeaf_block
> + *      checks an extended attribute (not directory) leaf block
> + */
> +static int check_ealeaf_block(struct gfs2_inode *ip, uint64_t block, int btype,
> +			      struct gfs2_buffer_head **bh, void *private)
>  {
>  	struct gfs2_buffer_head *leaf_bh = NULL;
>  	struct gfs2_sbd *sdp = ip->i_sbd;
> @@ -728,7 +731,7 @@ static int check_extended_leaf_eattr(struct gfs2_inode *ip, uint64_t *data_ptr,
>  				  gfs2_bad_block);
>  		return 1;
>  	}
> -	error = check_leaf_block(ip, el_blk, GFS2_METATYPE_ED, &bh, private);
> +	error = check_ealeaf_block(ip, el_blk, GFS2_METATYPE_ED, &bh, private);
>  	if (bh)
>  		brelse(bh);
>  	return error;
> @@ -769,7 +772,7 @@ static int check_eattr_leaf(struct gfs2_inode *ip, uint64_t block,
>  				    "Attribute leaf"), gfs2_bad_block);
>  		return 1;
>  	}
> -	return check_leaf_block(ip, block, GFS2_METATYPE_EA, bh, private);
> +	return check_ealeaf_block(ip, block, GFS2_METATYPE_EA, bh, private);
>  }
>  
>  static int check_eattr_entries(struct gfs2_inode *ip,




      reply	other threads:[~2011-08-12  9:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 21:00 [Cluster-devel] [Patch 07/44] fsck.gfs2: Rename function check_leaf to check_ealeaf_block Bob Peterson
2011-08-12  9:18 ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313140708.2704.23.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).