* [Cluster-devel] [Patch 12/44] fsck.gfs2: get rid of triple negative logic
@ 2011-08-11 21:03 Bob Peterson
2011-08-12 9:26 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2011-08-11 21:03 UTC (permalink / raw)
To: cluster-devel.redhat.com
From 62d7423184da8e291396cb54269612d501437006 Mon Sep 17 00:00:00 2001
From: Bob Peterson <rpeterso@redhat.com>
Date: Mon, 8 Aug 2011 14:44:46 -0500
Subject: [PATCH 12/44] fsck.gfs2: get rid of triple negative logic
This patch changes the logic of the code from being triple-negative
to single-negative so it won't twist your brain into knots.
rhbz#675723
---
gfs2/fsck/metawalk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index f2cd938..a4d7d3e 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -930,7 +930,7 @@ static int delete_block_if_notdup(struct gfs2_inode *ip, uint64_t block,
uint8_t q;
struct duptree *d;
- if (!valid_block(ip->i_sbd, block) != 0)
+ if (!valid_block(ip->i_sbd, block))
return -EFAULT;
q = block_type(block);
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [Patch 12/44] fsck.gfs2: get rid of triple negative logic
2011-08-11 21:03 [Cluster-devel] [Patch 12/44] fsck.gfs2: get rid of triple negative logic Bob Peterson
@ 2011-08-12 9:26 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2011-08-12 9:26 UTC (permalink / raw)
To: cluster-devel.redhat.com
Looks good,
Steve.
On Thu, 2011-08-11 at 17:03 -0400, Bob Peterson wrote:
> >From 62d7423184da8e291396cb54269612d501437006 Mon Sep 17 00:00:00 2001
> From: Bob Peterson <rpeterso@redhat.com>
> Date: Mon, 8 Aug 2011 14:44:46 -0500
> Subject: [PATCH 12/44] fsck.gfs2: get rid of triple negative logic
>
> This patch changes the logic of the code from being triple-negative
> to single-negative so it won't twist your brain into knots.
>
> rhbz#675723
> ---
> gfs2/fsck/metawalk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
> index f2cd938..a4d7d3e 100644
> --- a/gfs2/fsck/metawalk.c
> +++ b/gfs2/fsck/metawalk.c
> @@ -930,7 +930,7 @@ static int delete_block_if_notdup(struct gfs2_inode *ip, uint64_t block,
> uint8_t q;
> struct duptree *d;
>
> - if (!valid_block(ip->i_sbd, block) != 0)
> + if (!valid_block(ip->i_sbd, block))
> return -EFAULT;
>
> q = block_type(block);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-12 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-11 21:03 [Cluster-devel] [Patch 12/44] fsck.gfs2: get rid of triple negative logic Bob Peterson
2011-08-12 9:26 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).