From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Fri, 12 Aug 2011 10:26:55 +0100
Subject: [Cluster-devel] [Patch 13/44] dirent_repair needs to mark the
 buffer as modified
In-Reply-To: <953935204.544710.1313096628700.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
References: <953935204.544710.1313096628700.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
Message-ID: <1313141215.2704.30.camel@menhir>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Ack,

Steve.

On Thu, 2011-08-11 at 17:03 -0400, Bob Peterson wrote:
> >From fa744b806ad8655c9ed3a18fcbec1c7992735be5 Mon Sep 17 00:00:00 2001
> From: Bob Peterson <rpeterso@redhat.com>
> Date: Mon, 8 Aug 2011 14:47:49 -0500
> Subject: [PATCH 13/44] dirent_repair needs to mark the buffer as modified
> 
> This patch adds a call to bmodified to function dirent_repair.  Without
> setting the modified bit, directory repairs may be forgotten and never
> written back to disk, leaving the damage in place.
> 
> rhbz#675723
> ---
>  gfs2/fsck/metawalk.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
> index a4d7d3e..6bdea5a 100644
> --- a/gfs2/fsck/metawalk.c
> +++ b/gfs2/fsck/metawalk.c
> @@ -266,6 +266,7 @@ static int dirent_repair(struct gfs2_inode *ip, struct gfs2_buffer_head *bh,
>  		de->de_rec_len = GFS2_DIRENT_SIZE(de->de_name_len);
>  	}
>  	gfs2_dirent_out(de, (char *)dent);
> +	bmodified(bh);
>  	return 0;
>  }
>