From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Tue, 6 Sep 2011 13:00:13 +0100 Subject: [Cluster-devel] [PATCH 1/5] gfs2_edit: Initialize metafds fully in savemetaopen Message-ID: <1315310417-4833-1-git-send-email-anprice@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Coverity showed that savemetaopen() can return a metafd without initializing the gzfd member. This isn't currently a problem as we only use gzfd when it is set but this patch initializes the metafd fully to avoid future problems. Signed-off-by: Andrew Price --- gfs2/edit/savemeta.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c index 3a0e45e..9e5d111 100644 --- a/gfs2/edit/savemeta.c +++ b/gfs2/edit/savemeta.c @@ -211,7 +211,7 @@ static void warm_fuzzy_stuff(uint64_t wfsblock, int force) */ static struct metafd savemetaopen(char *out_fn, int gziplevel) { - struct metafd mfd; + struct metafd mfd = {-1, NULL, NULL, gziplevel}; char gzmode[3] = "w9"; char dft_fn[] = DFT_SAVE_FILE; @@ -233,7 +233,6 @@ static struct metafd savemetaopen(char *out_fn, int gziplevel) exit(1); } - mfd.gziplevel = gziplevel; if (gziplevel > 0) { gzmode[1] = '0' + gziplevel; mfd.gzfd = gzdopen(mfd.fd, gzmode); -- 1.7.6