From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 13/19] GFS2: Remove obsolete assert
Date: Thu, 8 Sep 2011 16:50:22 +0100 [thread overview]
Message-ID: <1315497028-8473-14-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1315497028-8473-1-git-send-email-swhiteho@redhat.com>
Given that a resource group has been locked, there is no reason why
we should not be able to allocate as many blocks as are free. The
al_requested parameter should really be considered as a minimum
number of blocks to be available. Should this limit be overshot,
there are other mechanisms which will prevent over allocation.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 5bfb970..08b3a80 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1077,15 +1077,8 @@ int gfs2_inplace_reserve_i(struct gfs2_inode *ip,
void gfs2_inplace_release(struct gfs2_inode *ip)
{
- struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode);
struct gfs2_alloc *al = ip->i_alloc;
- if (gfs2_assert_warn(sdp, al->al_alloced <= al->al_requested) == -1)
- fs_warn(sdp, "al_alloced = %u, al_requested = %u "
- "al_file = %s, al_line = %u\n",
- al->al_alloced, al->al_requested, al->al_file,
- al->al_line);
-
if (al->al_rgd_gh.gh_gl)
gfs2_glock_dq_uninit(&al->al_rgd_gh);
}
--
1.7.4
next prev parent reply other threads:[~2011-09-08 15:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 15:50 [Cluster-devel] Current -nmw tree content Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 01/19] GFS2: Clean up dir hash table reading Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 02/19] GFS2: Split data write & wait in fsync Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 03/19] GFS2: Fix bug-trap in ail flush code Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 04/19] GFS2: Make atime checks more efficient Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 05/19] GFS2: Fix inode allocation error path Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 06/19] GFS2: Fix bug trap and journaled data fsync Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 07/19] GFS2: Use ->dirty_inode() Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 08/19] GFS2: Clean up gfs2_create Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 09/19] GFS2: Fix lseek after SEEK_DATA, SEEK_HOLE have been added Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 10/19] GFS2: Use rbtree for resource groups and clean up bitmap buffer ref count scheme Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 11/19] GFS2: Make resource groups "append only" during life of fs Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 12/19] GFS2: Cache the most recently used resource group in the inode Steven Whitehouse
2011-09-08 15:50 ` Steven Whitehouse [this message]
2011-09-08 15:50 ` [Cluster-devel] [PATCH 14/19] GFS2: Call do_strip() directly from recursive_scan() Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 15/19] GFS2: Use cached rgrp in gfs2_rlist_add() Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 16/19] GFS2: Fix AIL flush issue during fsync Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 17/19] GFS2: Correctly set goal block after allocation Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 18/19] GFS2: Clean up ->page_mkwrite Steven Whitehouse
2011-09-08 15:50 ` [Cluster-devel] [PATCH 19/19] GFS2: Fix off-by-one in gfs2_blk2rgrpd Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315497028-8473-14-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).