From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/4] libgfs2: Fix "Value stored is never read" warnings
Date: Wed, 19 Aug 2009 08:47:30 -0400 (EDT) [thread overview]
Message-ID: <1316741366.770561250686050021.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1250670274-7794-4-git-send-email-andy@andrewprice.me.uk>
----- "Andrew Price" <andy@andrewprice.me.uk> wrote:
| Building with CC="clang --analyze" gave the following warnings:
|
| - misc.c:126:8: warning: Although the value stored to 'ret' is used
| in
| the enclosing expression, the value is never actually read from
| 'ret'
| - fs_geometry.c:82:3: warning: Value stored to 'rgsize_specified' is
| never read
| - gfs1.c:308:3: warning: Value stored to 'f' is never read
|
| This patch makes them go away.
|
| Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
| ---
(snip)
| + if (6 != ret)
Hi,
I prefer the form "if (ret != 6)" but this will work.
ACKed by Bob Peterson <rpeterso@redhat.com>
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2009-08-19 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 8:24 [Cluster-devel] [PATCH 0/4] gfs2_utils: Trivial patches Andrew Price
2009-08-19 8:24 ` [Cluster-devel] [PATCH 1/4] libgfs2: Fix 'dubious one-bit signed bitfield' sparse errors Andrew Price
2009-08-19 12:34 ` Bob Peterson
2009-08-19 8:24 ` [Cluster-devel] [PATCH 2/4] gfs2_quota: Fix sparse error Andrew Price
2009-08-19 12:35 ` Bob Peterson
2009-08-19 8:24 ` [Cluster-devel] [PATCH 3/4] libgfs2: Fix "Value stored is never read" warnings Andrew Price
2009-08-19 12:47 ` Bob Peterson [this message]
2009-08-19 8:24 ` [Cluster-devel] [PATCH 4/4] fsck.gfs2: Make block_mounters static Andrew Price
2009-08-19 12:49 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316741366.770561250686050021.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).