From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Wed, 19 Aug 2009 08:47:30 -0400 (EDT) Subject: [Cluster-devel] [PATCH 3/4] libgfs2: Fix "Value stored is never read" warnings In-Reply-To: <1250670274-7794-4-git-send-email-andy@andrewprice.me.uk> Message-ID: <1316741366.770561250686050021.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- "Andrew Price" wrote: | Building with CC="clang --analyze" gave the following warnings: | | - misc.c:126:8: warning: Although the value stored to 'ret' is used | in | the enclosing expression, the value is never actually read from | 'ret' | - fs_geometry.c:82:3: warning: Value stored to 'rgsize_specified' is | never read | - gfs1.c:308:3: warning: Value stored to 'f' is never read | | This patch makes them go away. | | Signed-off-by: Andrew Price | --- (snip) | + if (6 != ret) Hi, I prefer the form "if (ret != 6)" but this will work. ACKed by Bob Peterson Regards, Bob Peterson Red Hat File Systems