From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Mon, 26 Sep 2011 09:27:38 +0100
Subject: [Cluster-devel] [PATCH] gfs2/inode.c: local functions should be
	static
In-Reply-To: <201109231551.32939.hartleys@visionengravers.com>
References: <201109231551.32939.hartleys@visionengravers.com>
Message-ID: <1317025658.2744.0.camel@menhir>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On Fri, 2011-09-23 at 15:51 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
> 
> warning: symbol 'gfs2_initxattrs' was not declared. Should it be static?
> 
Where did you find this function? It is not in the upstream gfs2 code...

Steve.

> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> 
> ---
> 
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 5431de9..5f2b157 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -624,7 +624,7 @@ fail:
>  	return error;
>  }
>  
> -int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
>  		    void *fs_info)
>  {
>  	const struct xattr *xattr;